From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling
Date: Fri, 29 May 2015 13:32:45 +0100 [thread overview]
Message-ID: <20150529123245.GB8598@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <d0fdc6978692156725b97bac7cdde88f7b774b84.1432037840.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Tue, May 19, 2015 at 03:24:36PM +0300, Alberto Garcia wrote:
> @@ -32,26 +34,31 @@ class ThrottleTestCase(iotests.QMPTestCase):
> raise Exception("Device not found for blockstats: %s" % device)
>
> def setUp(self):
> - self.vm = iotests.VM().add_drive(self.test_img)
> + self.vm = iotests.VM()
> + for i in range(0, self.max_drives):
> + self.vm.add_drive(self.test_img)
Unique files are required, it's not safe to write to open the same image
file for writing multiple times.
This test case works with raw image files but could fail with image
formats like qcow2, vmdk, etc. These image formats are not designed for
multiple writers and the test could fail early due to image file
corruption.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-29 12:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 12:24 [Qemu-devel] [PATCH v8 0/8] Block Throttle Group Support Alberto Garcia
2015-05-19 12:24 ` [Qemu-devel] [PATCH 1/8] throttle: Extract timers from ThrottleState into a separate structure Alberto Garcia
2015-05-19 12:24 ` [Qemu-devel] [PATCH 2/8] throttle: Add throttle group infrastructure Alberto Garcia
2015-05-19 12:24 ` [Qemu-devel] [PATCH 3/8] throttle: Add throttle group infrastructure tests Alberto Garcia
2015-05-19 12:24 ` [Qemu-devel] [PATCH 4/8] throttle: Add throttle group support Alberto Garcia
2015-05-29 12:33 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-19 12:24 ` [Qemu-devel] [PATCH 5/8] throttle: acquire the ThrottleGroup lock in bdrv_swap() Alberto Garcia
2015-05-29 12:33 ` Stefan Hajnoczi
2015-05-19 12:24 ` [Qemu-devel] [PATCH 6/8] throttle: add the name of the ThrottleGroup to BlockDeviceInfo Alberto Garcia
2015-05-29 12:33 ` Stefan Hajnoczi
2015-05-19 12:24 ` [Qemu-devel] [PATCH 7/8] throttle: Update throttle infrastructure copyright Alberto Garcia
2015-05-29 12:33 ` Stefan Hajnoczi
2015-05-19 12:24 ` [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling Alberto Garcia
2015-05-29 12:32 ` Stefan Hajnoczi [this message]
2015-05-29 13:29 ` Alberto Garcia
2015-06-03 10:32 ` Stefan Hajnoczi
2015-06-03 10:33 ` [Qemu-devel] [PATCH v8 0/8] Block Throttle Group Support Stefan Hajnoczi
2015-06-03 13:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2015-04-10 13:35 [Qemu-devel] [PATCH v7 " Alberto Garcia
2015-04-10 13:35 ` [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529123245.GB8598@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).