From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyJT2-0003eG-5w for qemu-devel@nongnu.org; Fri, 29 May 2015 08:32:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyJSy-0007wg-Uj for qemu-devel@nongnu.org; Fri, 29 May 2015 08:32:52 -0400 Date: Fri, 29 May 2015 13:32:45 +0100 From: Stefan Hajnoczi Message-ID: <20150529123245.GB8598@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to support group throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2015 at 03:24:36PM +0300, Alberto Garcia wrote: > @@ -32,26 +34,31 @@ class ThrottleTestCase(iotests.QMPTestCase): > raise Exception("Device not found for blockstats: %s" % device) > =20 > def setUp(self): > - self.vm =3D iotests.VM().add_drive(self.test_img) > + self.vm =3D iotests.VM() > + for i in range(0, self.max_drives): > + self.vm.add_drive(self.test_img) Unique files are required, it's not safe to write to open the same image file for writing multiple times. This test case works with raw image files but could fail with image formats like qcow2, vmdk, etc. These image formats are not designed for multiple writers and the test could fail early due to image file corruption. --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVaFxtAAoJEJykq7OBq3PIbVwIAIGQJLL6BhK/0nI+EH1Qk20u TcPoPLs2a6FBH4B+EqmZJmYgXRI9p5EKJ/y2cYjY43/Ubsd1q2lAO7zjcckgwYFU KasnagjQbFGJu3eaRC0WOUXR14FcWEc0OpJUZ62nFU3K2WzV2NYZgf+NgeNykpcT of/cph5ePiy1B2rKACkvxKxHM3hK6njRG3gRk9jOFpK4y2Ms8OnFwJxt2yHJcWrU q/3kFaqrnE/raVKdoSmcwdaKLqY3nkQDhINyrEbjzmtGR02vrItnYX/GxaFx5wHr SFlOeZIEy3h4gNfmbg6AUh6xuKYrCK54DUzDdRxplVDgoDIpNuA6jOcKQ6nuWX0= =Ltru -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--