From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YyJY0-0001iw-47
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:38:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YyJXv-0001Nn-1M
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:38:00 -0400
Date: Fri, 29 May 2015 13:37:51 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150529123751.GG8598@stefanha-thinkpad.redhat.com>
References: <1432866133-21111-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="E69HUUNAyIJqGpVn"
Content-Disposition: inline
In-Reply-To: <1432866133-21111-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] mirror: Skip
 block_job_defer_to_main_loop if already in the main context
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: pbonzini@redhat.com, Jeff Cody <jcody@redhat.com>, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com


--E69HUUNAyIJqGpVn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 29, 2015 at 10:22:13AM +0800, Fam Zheng wrote:
> mirror_exit does the replacing, which requires source and target to be
> in sync, unfortunately we can't guarantee that before we have a complete
> block pause mechanism. So for non-dataplane block jobs, let's do the old
> thing as pre commit 5a7e7a0ba (block: let mirror blockjob run in BDS
> AioContext) - directly call mirror_exit().
>=20
> Dataplane case is taken care of in separate patches.
>=20
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/mirror.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Please CC Jeff Cody <jcody@redhat.com> on blockjob patches.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--E69HUUNAyIJqGpVn
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVaF2fAAoJEJykq7OBq3PI6kcIALTLe2CkJV0ZAEBeGwBA0Q+Y
N5001MS/kLBAAXuITSeVVwWCvyIlAyu/fmIc6T13lTisbf0npZ3L1lJVY8eUcRq9
hu6g/KuhW8By9QHHiC3ktW5NJlRjf8J1m6D6V4XYuHXifH/Dig3OCzEXieSiD6Mw
U0jUN63AYNkzjrMAHxEISFx47f/O9UgyGA6GZNFqV3Y05WVhSoiNg3sJl77L73/i
Hn623g4W62I42+eKp8kPfwY1BEi4F3zdAgoaid5ssSAkTkXyGqzItk3DFrXpk43K
kHTAILXTFuaKLucN5EIicKkSz9gLQpZNmNHcYVa/F6bLWM/bSWh1LfKMTdir2fg=
=bxr/
-----END PGP SIGNATURE-----

--E69HUUNAyIJqGpVn--