From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org,
"open list:Block layer core" <qemu-block@nongnu.org>,
armbru@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev: no need to drain+flush in hmp_drive_del
Date: Fri, 29 May 2015 13:41:12 +0100 [thread overview]
Message-ID: <20150529124112.GH8598@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1432822629-25401-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Thu, May 28, 2015 at 04:17:09PM +0200, Paolo Bonzini wrote:
> bdrv_close already does that, and in fact hmp_drive_del would need
> another drain after the flush (which bdrv_close does). So remove
> the duplication.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> blockdev.c | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-29 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 14:17 [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del Paolo Bonzini
2015-05-28 14:21 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-05-29 1:45 ` [Qemu-devel] " Fam Zheng
2015-05-29 12:41 ` Stefan Hajnoczi [this message]
2015-06-25 12:18 ` Paolo Bonzini
2015-06-26 8:53 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529124112.GH8598@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).