From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YyJbF-0002sf-00
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:41:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YyJb9-00026U-UT
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:41:20 -0400
Date: Fri, 29 May 2015 13:41:12 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150529124112.GH8598@stefanha-thinkpad.redhat.com>
References: <1432822629-25401-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="G44BJl3Aq1QbV/QL"
Content-Disposition: inline
In-Reply-To: <1432822629-25401-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev: no need to
 drain+flush in hmp_drive_del
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "open list:Block layer core" <qemu-block@nongnu.org>, armbru@redhat.com


--G44BJl3Aq1QbV/QL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 28, 2015 at 04:17:09PM +0200, Paolo Bonzini wrote:
> bdrv_close already does that, and in fact hmp_drive_del would need
> another drain after the flush (which bdrv_close does).  So remove
> the duplication.
>=20
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  blockdev.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--G44BJl3Aq1QbV/QL
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVaF5oAAoJEJykq7OBq3PIZl8IAKitiZdNesf7G31AAcHKSEAR
um53ihK5HD3UyvXyMxr+hxGBLJy+INXuOlPWsZZUYepWDJ5cyvXPxCfDpnIFSO9Q
OBWIormAbFFzK35ermTl5+OS8a7kyF4kdJi1WWzHIyGISPCofBxJbbDXcGIKEeBy
aXg3XqETMe+H5cdF0OReqt7QfATOCA5Ibe+2t94GQsWMNWECmcsXo3PBNganLXDp
m3BBxcz+QDhXnaEI4FlGfG1vmbCS0C+R5Q9tjjT6OhfFwnc4zSDPKRuD+5dY9jbk
1LS9ATLWesqiYROEhEYEe4TtPDUlznvI45sVmKkhFy6fke4hSXia6hQnAwwVD48=
=CZAq
-----END PGP SIGNATURE-----

--G44BJl3Aq1QbV/QL--