From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40863)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YyJdU-0007JI-FW
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:43:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YyJdN-0002xa-5Y
	for qemu-devel@nongnu.org; Fri, 29 May 2015 08:43:40 -0400
Date: Fri, 29 May 2015 13:43:29 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150529124329.GI8598@stefanha-thinkpad.redhat.com>
References: <1432822903-25821-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="xQR6quUbZ63TTuTU"
Content-Disposition: inline
In-Reply-To: <1432822903-25821-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev: no need to drain in
 qmp_block_commit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "open list:Block layer core" <qemu-block@nongnu.org>


--xQR6quUbZ63TTuTU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 28, 2015 at 04:21:43PM +0200, Paolo Bonzini wrote:
> Draining is not necessary, I/O can happen as soon as the
> commit coroutine yields.  Draining can be necessary before
> reopening the file for read/write, or while modifying the
> backing file chain, but that is done separately in
> bdrv_reopen_multiple or bdrv_close; this particular
> bdrv_drain_all does nothing for that.
>=20
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  blockdev.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--xQR6quUbZ63TTuTU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVaF7xAAoJEJykq7OBq3PIG8oH/3W7HKTpry3TMFlBRLFrRAap
hlRJUjkglx01WsM+1vTJnQJSSv3HZoTbJ1kzYObG6OP/Pol3a4y6NnkJQwrPYzw7
ohSWZ0L3MtrgU+aWIbBH/7iD7Bg3HAiP7Ir69iqYBI9QFPxrgwT1TXu/b0XO1i0j
OZN00JBPLFoH2ZaelbT1knYJKiIMMV/4QfwOdLVxfpst5/ACQffM8vld0DKdJMX6
ZkC5CLyCiTc5YcIZKW/B7tM2XyJOyK2wRG/vFHjqN0p+e5fDBf4HqQ0619sCS8gw
q9XrZ4RAn/TGfnq/DdAxV8CSNNT+JFPrN2K+5Tnc3MTa983dSMkSB9p2+R3nBHM=
=zDMk
-----END PGP SIGNATURE-----

--xQR6quUbZ63TTuTU--