From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyKB5-0000LR-AB for qemu-devel@nongnu.org; Fri, 29 May 2015 09:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyKB2-0006iA-3C for qemu-devel@nongnu.org; Fri, 29 May 2015 09:18:23 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:37497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyKB1-0006i4-T8 for qemu-devel@nongnu.org; Fri, 29 May 2015 09:18:20 -0400 Received: by wifw1 with SMTP id w1so23561049wif.0 for ; Fri, 29 May 2015 06:18:19 -0700 (PDT) Date: Fri, 29 May 2015 14:18:16 +0100 From: Stefan Hajnoczi Message-ID: <20150529131816.GM8598@stefanha-thinkpad.redhat.com> References: <1432743412-15943-1-git-send-email-stefanha@redhat.com> <1432743412-15943-2-git-send-email-stefanha@redhat.com> <20150527193917.6fa118d0@thh440s> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WuedheRyq6FDfQ9j" Content-Disposition: inline In-Reply-To: <20150527193917.6fa118d0@thh440s> Subject: Re: [Qemu-devel] [PATCH 1/5] net: add missing "netmap" to host_net_devices[] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster --WuedheRyq6FDfQ9j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 27, 2015 at 07:39:17PM +0200, Thomas Huth wrote: > On Wed, 27 May 2015 17:16:48 +0100 > Stefan Hajnoczi wrote: >=20 > > Although hmp-commands.hx lists "netmap" as a valid host_net_add type, > > the command rejects it because it's missing from the list. > >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > net/net.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/net/net.c b/net/net.c > > index db6be12..c5349d2 100644 > > --- a/net/net.c > > +++ b/net/net.c > > @@ -58,6 +58,9 @@ const char *host_net_devices[] =3D { > > #ifdef CONFIG_NET_BRIDGE > > "bridge", > > #endif > > +#ifdef CONFIG_NETMAP > > + "netmap", > > +#endif > > #ifdef CONFIG_SLIRP > > "user", > > #endif >=20 > Did you consider to remove it from the help text in hmp-commands.hx > instead? > That would force the users to use "netdev_add" for this instead - one > more reason to get away from the legacy "net" syntax ;-) There's no reason to artifically limit the command and the intention of the documentation was clear. Stefan --WuedheRyq6FDfQ9j Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVaGcYAAoJEJykq7OBq3PIyEAH/AkEH8HrHKcyD89Nq5p2f1Al hjyQ6ecQ00N8zbnTU5NiDSq9SX6gxoKeTWQFFqHpZLQ2i5NY1VbgSumc2nXet9/c GfnORgEFNrSl+RiVEJghnV0tXaJ0qFBmwhjHOhdIt8g3NoDrFUK1KYF9mulmUOJB rIqu+xg3VDd3x2coGt9QgoEgDl90X9G5Jg/gEiRc0klRPyEO6zDR1CgBH7XJvUpo Kzwl9A5idoJerWoU20LdmvWrRmnxxY3g8kCzwziKzZVA5c2LAnXaf6Pc8VE693/v k/qZRy5te8p1J93t+QI6+syZgcmepoYzwZS3AmgpFdzj0pfNECo7TfEPCgyRZVw= =fBiv -----END PGP SIGNATURE----- --WuedheRyq6FDfQ9j--