From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YyMXQ-0003o3-BJ
	for qemu-devel@nongnu.org; Fri, 29 May 2015 11:49:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YyMXN-0003WS-5R
	for qemu-devel@nongnu.org; Fri, 29 May 2015 11:49:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33367)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YyMXN-0003WK-0F
	for qemu-devel@nongnu.org; Fri, 29 May 2015 11:49:33 -0400
Date: Fri, 29 May 2015 16:49:28 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150529154927.GB20215@work-vm>
References: <1432911708-22845-1-git-send-email-dgilbert@redhat.com>
	<1432911708-22845-3-git-send-email-dgilbert@redhat.com>
	<556887A1.20508@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <556887A1.20508@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> 
> 
> On 29/05/2015 17:01, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > Newer glib has support for checking that applications aren't
> > using newer glib calls than they should be.
> > 
> > The support for the check only went into glib 2.32 and it only
> > has macros for version 2.26 upwards; although we only insist
> > on 2.22 at the moment, I set the glib checks to the earliest of 2.26,
> > it wont cause problems on anything <2.32 since the checks aren't
> > there.
> 
> I think we need 2.32 minimum, because we use the 2.32 mutex/condvar
> functions if available.

Are all those done via glib-compat.h ?
Note that in the patch I turn off the version checks at the top of glib-compat.h
on the assumption that anything trying to use it knows what it is doing.

Dave

> 
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK