From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YyMj7-00016n-3M
	for qemu-devel@nongnu.org; Fri, 29 May 2015 12:01:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YyMj2-0007rc-AA
	for qemu-devel@nongnu.org; Fri, 29 May 2015 12:01:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37515)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YyMj2-0007rP-54
	for qemu-devel@nongnu.org; Fri, 29 May 2015 12:01:36 -0400
Date: Fri, 29 May 2015 17:01:31 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150529160130.GC20215@work-vm>
References: <1432911708-22845-1-git-send-email-dgilbert@redhat.com>
	<1432911708-22845-3-git-send-email-dgilbert@redhat.com>
	<CAFEAcA_01DtMB5H3vPyGZpjw5=jKvucQhpBvcNGH-KPTfKzb5A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_01DtMB5H3vPyGZpjw5=jKvucQhpBvcNGH-KPTfKzb5A@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: pbonzini@redhat.com, QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

* Peter Maydell (peter.maydell@linaro.org) wrote:
> On 29 May 2015 at 16:01, Dr. David Alan Gilbert (git)
> <dgilbert@redhat.com> wrote:
> > --- a/include/glib-compat.h
> > +++ b/include/glib-compat.h
> > @@ -16,6 +16,12 @@
> >  #ifndef QEMU_GLIB_COMPAT_H
> >  #define QEMU_GLIB_COMPAT_H
> >
> > +/*
> > + * The source file including this compat header knows it's using newer glib
> > + * functions than we generally allow, so don't warn about it.
> > + */
> > +#undef GLIB_VERSION_MIN_REQUIRED
> > +#undef GLIB_VERSION_MAX_ALLOWED
> >  #include <glib.h>
> 
> ...but glib-compat.h is included by qemu-common.h and in general
> the point is that code anywhere in QEMU can assume the compat
> versions exist, so it feels like this will defeat the point.

Hmm, a lot of files seem to include glib.h directly.  But OK,
so then Paolo is suggesting setting the minimum to 2.32
which I can do, but then that wouldn't stop something that's
in 2.22-2.32 but not in glib-compat.h

Dave

> 
> -- PMM
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK