From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1YzXOs-0000dX-TN
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 17:37:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1YzXOq-0003y8-4i
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 17:37:38 -0400
Received: from terminus.zytor.com ([2001:1868:205::10]:60510
	helo=mail.zytor.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1YzXOp-0003xy-SZ
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 17:37:36 -0400
Date: Mon, 1 Jun 2015 18:37:14 -0300
From: Paulo Alcantara <pcacjr@zytor.com>
Message-ID: <20150601183714.1d9f2e1e@zytor.com>
In-Reply-To: <dc7cb0e10e7159fd7c7fb5389820fecc.squirrel@www.zytor.com>
References: <1432686576-14816-1-git-send-email-pcacjr@zytor.com>
	<1433023482-25721-1-git-send-email-pcacjr@zytor.com>
	<556C2067.1030607@redhat.com>
	<dc7cb0e10e7159fd7c7fb5389820fecc.squirrel@www.zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/3] ich9: add TCO interface emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: seabios@seabios.org, Paulo Alcantara <pcacjr@gmail.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Mon, 1 Jun 2015 10:38:32 -0300
"Paulo Alcantara" <pcacjr@zytor.com> wrote:

> On Mon, June 1, 2015 6:05 am, Paolo Bonzini wrote:
> >
> >
> > On 31/05/2015 00:04, Paulo Alcantara wrote:
> >> +    case TCO_RLD:
> >> +        tr->timeouts_no = 0;
> >> +        if (can_start_tco_timer(tr)) {
> >> +            tr->tco.rld = tr->tco.tmr;
> >> +            tco_timer_reload(tr);
> >> +        } else {
> >> +            tr->tco.rld = val;
> >
> > Please mask out bits outside TCO_RLD_MASK here, same as you do for
> > TCO1_STS_MASK and friends.
> 
> OK.

Hrm - actually, I can't do that. Unlike TCO1_STS, TCO2_STS and TCO1_CNT
registers that have some bits which are disabled by writing 1 to them
-- that's why I mask them out before updating -- the TCO_RLD and
TCO_TMR registers only have bits 15:10 marked as _reserved_ and I
should not zero them out. Does that seem correct to you?

Thanks,

Paulo

-- 
Paulo Alcantara, C.E.S.A.R
Speaking for myself only.