From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzhlZ-00054O-OM for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:41:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzhlY-00066p-Nh for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:41:45 -0400 Date: Tue, 2 Jun 2015 10:41:41 +0200 From: Martin Kletzander Message-ID: <20150602084141.GA28929@wheatley> References: <1433232329-14983-1-git-send-email-mkletzan@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] arm: Fix invalid assert logic in op_helper.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , QEMU Developers --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Tue, Jun 02, 2015 at 09:10:23AM +0100, Peter Maydell wrote: >On 2 June 2015 at 09:05, Martin Kletzander wrote: >> Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it >> according to the comment above as currently the build fails with >> gcc-5.1.0. >> >> Signed-off-by: Martin Kletzander >> --- >> target-arm/op_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c >> index 3f5b9ab5963b..7583ae71217b 100644 >> --- a/target-arm/op_helper.c >> +++ b/target-arm/op_helper.c >> @@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void *rip, uint32_t syndrome) >> /* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is >> * a bug in the access function. >> */ >> - assert(!arm_is_secure(env) && !arm_current_el(env) == 3); >> + assert(!arm_is_secure(env) && arm_current_el(env) != 3); >> target_el = 2; >> break; >> case CP_ACCESS_TRAP_EL3: > >Thanks, but there are already two versions of this patch on the list. > Oh, I'm very sorry for that, I must've missed them. I'm still missing the skill to not miss relevant information from the list. Have a nice day, Martin --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVbWxFAAoJEAgfwp8kF4bd0pMP/AoI5FNqC2jFmi+RGVPckG65 Zg0Int7Z2LkoMsIh52eJ4t0XEBQ36VdrsVYN3BdzNM+2QxOPq3BbIJb4cVPwuwTL Z0OvxA/sHHjv1ZDlIeRPYNqLomLHCVKDDqnhb0qTJ6nwmFqKihO0upRgkY8dU1EQ ybftb8ERfW0UASSZ2WmudOba1pQCRuhZm4wGB9DkyR72fX/kHseV+5ekfQ3AoSGm 5ywr9Foa+fHQ3NeJbWJaof0RyX7XTqBIrHwCzRwlnBU4XVBqjn5Kn+iwZLgbsAmI hG7D2wW2HdmwwuVxWBR3VAGQbkooJ68l1XwP+Kdlv1U/2ATEcwqAQhjRRhfILk12 8nSL18m++EBlf1QSiYgiLSlz4uMM5fLIuc7xbgYPuSJ6/L+Ujk0pfwyHij5CBdjG 3OZKdGhRI/J8tkrqEVAgW6oSZ0n/+saTJKZqR4kisuTeFhemfy1q/hUZmNu75k62 QujdDzYbcZdWW0O4V6vtcb79ree0h9mThQrg4MToAnr8zboZki2ebrPe7+cnD1J5 WzEBfkKATkTRgKLh+GUgFrmSTwSi6t7YPKnSvBFg5DTSHLW0XGXDCXNwzXMBqtHZ lOrL6nL6WZMd0oJQl1JVd9j8pIts0jOa+BYwPPLeZru72nK1eLouNrUBfPV82+Kw y/H4zIctvjmXkZW9PQmG =Dmn1 -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--