From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59875)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yzg0K-0003PV-EP
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 02:48:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yzg0H-0003fH-7b
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 02:48:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49800)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yzg0H-0003f5-2S
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 02:48:49 -0400
Date: Tue, 2 Jun 2015 08:48:44 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150602084729-mutt-send-email-mst@redhat.com>
References: <1433205175-1255386-1-git-send-email-stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433205175-1255386-1-git-send-email-stefanb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] tpm: Add missing common TPM SSDT file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanb@us.ibm.com

On Mon, Jun 01, 2015 at 08:32:55PM -0400, Stefan Berger wrote:
> This patch adds the missing common SSDT TPM file.
> 
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

I posted this too. But we really should just get rid of all this: we
have already removed most ASL code except for the DSDT.

> ---
>  hw/i386/ssdt-tpm-common.dsl | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 hw/i386/ssdt-tpm-common.dsl
> 
> diff --git a/hw/i386/ssdt-tpm-common.dsl b/hw/i386/ssdt-tpm-common.dsl
> new file mode 100644
> index 0000000..9da4970
> --- /dev/null
> +++ b/hw/i386/ssdt-tpm-common.dsl
> @@ -0,0 +1,36 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> +
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> +
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +/*
> + * Common parts for TPM 1.2 and TPM 2 (with slight differences for PPI)
> + * to be #included
> + */
> +
> +
> +    External(\_SB.PCI0.ISA, DeviceObj)
> +    Scope(\_SB.PCI0.ISA) {
> +        /* TPM with emulated TPM TIS interface */
> +        Device (TPM) {
> +            Name (_HID, EisaID ("PNP0C31"))
> +            Name (_CRS, ResourceTemplate ()
> +            {
> +                Memory32Fixed (ReadWrite, TPM_TIS_ADDR_BASE, TPM_TIS_ADDR_SIZE)
> +                IRQNoFlags () {TPM_TIS_IRQ}
> +            })
> +            Method (_STA, 0, NotSerialized) {
> +                Return (0x0F)
> +            }
> +        }
> +    }
> -- 
> 1.9.3