Re: [Qemu-devel] [PATCH] sheepdog: Fix error message if failed to load vmstate

[Fam Zheng <famz@redhat.com>]

On Tue, 06/02 13:16, Michael Tokarev wrote:
> 02.06.2015 12:32, Fam Zheng wrote:
> >          if (ret < 0) {
> > -            error_report("failed to save vmstate %s", strerror(errno));
> > +            if (load) {
> > +                error_report("failed to load vmstate %s", strerror(errno));
> > +            } else {
> > +                error_report("failed to save vmstate %s", strerror(errno));
> > +            }
> 
>  +            error_report("failed to %s vmstate: %s", load ? "load" : "save", strerror(errno));

The reason I didn't use a one-liner was, "git grep 'failed to load vmstate'"
in the code base would just work, besides my eyes also like the readability.

> 
> (note also the addition of ":")

Yes that applies to all error_report() in this file.

> (besides what Kevin said).
> 
> Thanks,

Thanks,

Fam