Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

[Michael Tokarev]

26.05.2015 12:25, Chen Hanxiao wrote:
> s/interation/iteration
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
> ---
>  docs/writing-qmp-commands.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/writing-qmp-commands.txt b/docs/writing-qmp-commands.txt
> index f3df206..ab1fdd3 100644
> --- a/docs/writing-qmp-commands.txt
> +++ b/docs/writing-qmp-commands.txt
> @@ -598,7 +598,7 @@ stored in its "value" member. In our example, the "value" member is a pointer
>  to an TimerAlarmMethod instance.
>  
>  Notice that the "current" variable is used as "true" only in the first
> -interation of the loop. That's because the alarm timer method in use is the
> +iteration of the loop. That's because the alarm timer method in use is the
>  first element of the alarm_timers array. Also notice that QAPI lists are handled
>  by hand and we return the head of the list.

Applied to -trivial, thank you!

Marcus: I don't think such obvious and trivial changes needs to be re-sent
to -devel. Ofcourse it is better to send things to -devel rigth away, but
requiring to resent is a bit over the top.  I think anyway :)

/mjt

Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

[Michael Tokarev]

28.05.2015 15:12, Markus Armbruster wrote:
> Michael Tokarev <mjt@tls.msk.ru> writes:
[]
>> Marcus: I don't think such obvious and trivial changes needs to be re-sent
>> to -devel. Ofcourse it is better to send things to -devel rigth away, but
>> requiring to resent is a bit over the top.  I think anyway :)
> 
> Patches must be posted to -devel for review.
> 
> If you accept patches sent just to -trivial, then the only post to
> -devel will be your pull request, where it most probably won't get
> review.

Obvious typo fix in comment or doc don't really need a big review.
That's where the "too trivial" border can be drawn.

Just to be clear: I'm not, in any way, against posting things to -devel,
things SHOULD be posted to -devel.  But once a thing has been posted
like this one, just to -trivial, and it really _is_ trivial and obvious,
it is enough to say somehting among "This one is okay, but the next time
please send to -devel too".

Thanks,

/mjt

> Judging from my own experience, no patch is too trivial to screw up.
> Play it safe, post to -devel for review always.  Resending a trivial
> patch isn't exactly a big burden :)
> 

Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

[Markus Armbruster]

Michael Tokarev <mjt@tls.msk.ru> writes:

> 28.05.2015 15:12, Markus Armbruster wrote:
>> Michael Tokarev <mjt@tls.msk.ru> writes:
> []
>>> Marcus: I don't think such obvious and trivial changes needs to be re-sent
>>> to -devel. Ofcourse it is better to send things to -devel rigth away, but
>>> requiring to resent is a bit over the top.  I think anyway :)
>> 
>> Patches must be posted to -devel for review.
>> 
>> If you accept patches sent just to -trivial, then the only post to
>> -devel will be your pull request, where it most probably won't get
>> review.
>
> Obvious typo fix in comment or doc don't really need a big review.
> That's where the "too trivial" border can be drawn.

I don't want us to get into the "is this trivial enough to go in without
review" business.

[...]

Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

[Peter Maydell]

On 28 May 2015 at 15:05, Markus Armbruster <armbru@redhat.com> wrote:
> Michael Tokarev <mjt@tls.msk.ru> writes:
>
>> 28.05.2015 15:12, Markus Armbruster wrote:
>>> Patches must be posted to -devel for review.
>>>
>>> If you accept patches sent just to -trivial, then the only post to
>>> -devel will be your pull request, where it most probably won't get
>>> review.
>>
>> Obvious typo fix in comment or doc don't really need a big review.
>> That's where the "too trivial" border can be drawn.
>
> I don't want us to get into the "is this trivial enough to go in without
> review" business.

Yes, in general I agree. Nothing in our documentation says "send only to
-trivial", and it's not a very big deal to ask for a resend on the
odd occasion somebody does it by mistake.

thanks
-- PMM

[Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

[Chen Hanxiao]

s/interation/iteration

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
---
 docs/writing-qmp-commands.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/writing-qmp-commands.txt b/docs/writing-qmp-commands.txt
index f3df206..ab1fdd3 100644
--- a/docs/writing-qmp-commands.txt
+++ b/docs/writing-qmp-commands.txt
@@ -598,7 +598,7 @@ stored in its "value" member. In our example, the "value" member is a pointer
 to an TimerAlarmMethod instance.
 
 Notice that the "current" variable is used as "true" only in the first
-interation of the loop. That's because the alarm timer method in use is the
+iteration of the loop. That's because the alarm timer method in use is the
 first element of the alarm_timers array. Also notice that QAPI lists are handled
 by hand and we return the head of the list.
 
-- 
2.1.0

Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

On Fri, May 29, 2015 at 06:16:07AM -0400, Chen Hanxiao wrote:
> s/interation/iteration
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
> ---
>  docs/writing-qmp-commands.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]