Re: [Qemu-devel] [PATCH v3 4/4] qmp/hmp: add rocker device support

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Fri, May 29, 2015 at 07:01:49AM -0700, sfeldma@gmail.com wrote:
> +void hmp_rocker_of_dpa_flows(Monitor *mon, const QDict *qdict)
> +{
> +    RockerOfDpaFlowList *list, *info;
> +    const char *name = qdict_get_str(qdict, "name");
> +    uint32_t tbl_id = qdict_get_try_int(qdict, "tbl_id", -1);
> +    Error *errp = NULL;
> +
> +    list = qmp_query_rocker_of_dpa_flows(name, tbl_id != -1, tbl_id, &errp);
> +    if (errp != NULL) {
> +        hmp_handle_error(mon, &errp);
> +        return;
> +    }
> +
> +    monitor_printf(mon, "prio tbl hits key(mask) --> actions\n");
> +
> +    for (info = list; info; info = info->next) {
> +        RockerOfDpaFlow *flow = info->value;
> +        RockerOfDpaFlowKey *key = flow->key;
> +        RockerOfDpaFlowMask *mask = flow->mask;
> +        RockerOfDpaFlowAction *action = flow->action;
> +
> +        if (flow->hits) {
> +            monitor_printf(mon, "%-4d %-3d %-4ld",
> +                           key->priority, key->tbl_id, flow->hits);

flow->hits is uint64_t so I changed the format string to use %-4" PRIu64
when merging the patches.  This way it compiles cleanly on 32-bit hosts.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]