From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yznmb-0001qF-UE for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YznmY-0002F4-PD for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:07:13 -0400 Received: from mail-wg0-x236.google.com ([2a00:1450:400c:c00::236]:35399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznmY-0002Ey-IN for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:07:10 -0400 Received: by wgme6 with SMTP id e6so142593066wgm.2 for ; Tue, 02 Jun 2015 08:07:10 -0700 (PDT) Date: Tue, 2 Jun 2015 16:07:06 +0100 From: Stefan Hajnoczi Message-ID: <20150602150706.GC8199@stefanha-thinkpad.redhat.com> References: <1432908109-31559-1-git-send-email-sfeldma@gmail.com> <1432908109-31559-5-git-send-email-sfeldma@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+" Content-Disposition: inline In-Reply-To: <1432908109-31559-5-git-send-email-sfeldma@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3 4/4] qmp/hmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com Cc: jiri@resnulli.us, qemu-devel@nongnu.org, dsahern@gmail.com --ZwgA9U+XZDXt4+m+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 29, 2015 at 07:01:49AM -0700, sfeldma@gmail.com wrote: > +void hmp_rocker_of_dpa_flows(Monitor *mon, const QDict *qdict) > +{ > + RockerOfDpaFlowList *list, *info; > + const char *name = qdict_get_str(qdict, "name"); > + uint32_t tbl_id = qdict_get_try_int(qdict, "tbl_id", -1); > + Error *errp = NULL; > + > + list = qmp_query_rocker_of_dpa_flows(name, tbl_id != -1, tbl_id, &errp); > + if (errp != NULL) { > + hmp_handle_error(mon, &errp); > + return; > + } > + > + monitor_printf(mon, "prio tbl hits key(mask) --> actions\n"); > + > + for (info = list; info; info = info->next) { > + RockerOfDpaFlow *flow = info->value; > + RockerOfDpaFlowKey *key = flow->key; > + RockerOfDpaFlowMask *mask = flow->mask; > + RockerOfDpaFlowAction *action = flow->action; > + > + if (flow->hits) { > + monitor_printf(mon, "%-4d %-3d %-4ld", > + key->priority, key->tbl_id, flow->hits); flow->hits is uint64_t so I changed the format string to use %-4" PRIu64 when merging the patches. This way it compiles cleanly on 32-bit hosts. --ZwgA9U+XZDXt4+m+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVbcaaAAoJEJykq7OBq3PIM/4H/RwGSsbQEBlYxfupSinON3LH oYTGznpGcsincnsJ4PYYvlNw36tRGWWGOm8dU632BXqJf1ozZykDu2l2RAWZH9qc N8ytN9LqBvDOALfwCxU6wf1OIEGtqBpShpCWjzBlGwn8h/Ztu9SoxlRGy7R6GS8I 6PDNSzi7htOlZUcRbNNqkoLCHhCLwny2YYjX5kFPYiH/ky57kVsbIs4X9Q5IOEpf qKTUadgSDc2sjoAJVf9OHDE4U2FD/ScnCVrRblfIHLx1XILVq1Mkh+eW9TzMThVI H4ZDbA/R5LMf1E065bLXOBRke/GuQOobtVqClXum8D1sN3yGtRYS+xYf7UX8jK8= =giPS -----END PGP SIGNATURE----- --ZwgA9U+XZDXt4+m+--