From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznoZ-00044e-D8 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:09:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YznoU-0002be-Ty for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:09:15 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:37843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznoU-0002bV-NB for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:09:10 -0400 Received: by wifw1 with SMTP id w1so148748039wif.0 for ; Tue, 02 Jun 2015 08:09:10 -0700 (PDT) Date: Tue, 2 Jun 2015 16:09:07 +0100 From: Stefan Hajnoczi Message-ID: <20150602150907.GD8199@stefanha-thinkpad.redhat.com> References: <1432908109-31559-1-git-send-email-sfeldma@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YToU2i3Vx8H2dn7O" Content-Disposition: inline In-Reply-To: <1432908109-31559-1-git-send-email-sfeldma@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3 0/4] rocker device updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com Cc: jiri@resnulli.us, qemu-devel@nongnu.org, dsahern@gmail.com --YToU2i3Vx8H2dn7O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 29, 2015 at 07:01:45AM -0700, sfeldma@gmail.com wrote: > From: Scott Feldman >=20 > v3: >=20 > Address review comments from Stefan Hajnoczi: >=20 > - Add missing hw/net/rocker/qmp-norocker.c file. > - Add missing curly brackets to a for loop >=20 > v2: >=20 > Address some review comments by Stefan Hajnoczi: see individual patches f= or > v1->v2 changes. >=20 > v1: >=20 > Some rocker device updates we've been holding onto waiting for base rocker > device to be pulled into 2.4. David added support for the device to retu= rn the > physical port name, which in turn can be used by the OS to name the inter= face. > I added a small change the bringe link up/down when port is enabled/disab= led. >=20 > The big addition is adding qmp/hmp support to rocker. This was included = in the > original rocker device patch set, but pulled as there where last-minute i= ssues > with building on non-PCI targets. These issues have been addressed by st= ubbing > out qmp/hmp support when rocker device is built for non-PCI targets. >=20 > David Ahern (1): > rocker: Add support for phys name >=20 > Scott Feldman (3): > rocker: update tests using hw-derived interface names > rocker: bring link up/down on PHY enable/disable > qmp/hmp: add rocker device support >=20 > docs/specs/rocker.txt | 1 + > hmp-commands.hx | 24 ++++ > hmp.c | 303 +++++++++++++++++++++++++++++++++++= ++++ > hmp.h | 4 + > hw/net/Makefile.objs | 1 + > hw/net/rocker/qmp-norocker.c | 50 +++++++ > hw/net/rocker/rocker.c | 68 ++++++++- > hw/net/rocker/rocker_fp.c | 29 +++- > hw/net/rocker/rocker_fp.h | 2 + > hw/net/rocker/rocker_hw.h | 1 + > hw/net/rocker/rocker_of_dpa.c | 312 +++++++++++++++++++++++++++++++++++= ++++++ > monitor.c | 28 ++++ > qapi-schema.json | 3 + > qapi/rocker.json | 286 +++++++++++++++++++++++++++++++++++= ++ > qmp-commands.hx | 97 +++++++++++++ > tests/rocker/bridge | 25 ++-- > tests/rocker/bridge-stp | 25 ++-- > tests/rocker/bridge-vlan | 37 +++-- > tests/rocker/bridge-vlan-stp | 37 +++-- > tests/rocker/port | 8 +- > 20 files changed, 1263 insertions(+), 78 deletions(-) > create mode 100644 hw/net/rocker/qmp-norocker.c > create mode 100644 qapi/rocker.json Thanks, applied to my master tree: https://github.com/stefanha/qemu/commits/master Stefan --YToU2i3Vx8H2dn7O Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVbccTAAoJEJykq7OBq3PIqQ8IAKZrJn3Bcrv/nlIPd3hL1/Zn zUGmOc4QQdvsctIR1XdrVHFvrn1bdOVoYfGYS9foARitG1Jib2hXo0N1gv2tmD3V RcJhEwvoIBqg2CJ86whNvwbxDZ1OpJvUQeLz65oRPx9UdRprc9pPioV+gJm/b0pc hy4jCw3oWUltxvqG3vv67G+3m07dB0d5SOU8wFOnDtaGQ67efwN08FKTfDh9k2WS f2BNBxTutmyrMwiVmIOjW3IghqFmC5duuwnQp2hqTs1mBbh+ZqAf6I05nXtMvIgT Oi3+kc9sm1Fe+825cOaf3LUDLHTv7APgFUXZGAwKqfwYlhil5ALmt+zx/G/Vzjk= =FzLo -----END PGP SIGNATURE----- --YToU2i3Vx8H2dn7O--