From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzm9N-0002Sj-Qc for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:22:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzm9J-0000YD-IT for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:22:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzm9J-0000Y7-DC for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:22:33 -0400 Date: Tue, 2 Jun 2015 15:22:30 +0200 From: "Michael S. Tsirkin" Message-ID: <20150602151740-mutt-send-email-mst@redhat.com> References: <1433205175-1255386-1-git-send-email-stefanb@linux.vnet.ibm.com> <20150602084729-mutt-send-email-mst@redhat.com> <556DAC35.10307@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <556DAC35.10307@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] tpm: Add missing common TPM SSDT file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanb@us.ibm.com On Tue, Jun 02, 2015 at 09:14:29AM -0400, Stefan Berger wrote: > On 06/02/2015 02:48 AM, Michael S. Tsirkin wrote: > >On Mon, Jun 01, 2015 at 08:32:55PM -0400, Stefan Berger wrote: > >>This patch adds the missing common SSDT TPM file. > >> > >>Signed-off-by: Stefan Berger > >I posted this too. But we really should just get rid of all this: we > >have already removed most ASL code except for the DSDT. > > Yes, I will do that. Though for reviewing I think ASL is still easier to > understand. > > Stefan A bit, but once you get into more trickery, like you do with ifdefs with QEMU-external TPM, it becomes less clear. -- MST