Re: [Qemu-devel] [PATCH] tpm: Add missing common TPM SSDT file

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jun 02, 2015 at 09:23:35AM -0400, Stefan Berger wrote:
> On 06/02/2015 09:22 AM, Michael S. Tsirkin wrote:
> >On Tue, Jun 02, 2015 at 09:14:29AM -0400, Stefan Berger wrote:
> >>On 06/02/2015 02:48 AM, Michael S. Tsirkin wrote:
> >>>On Mon, Jun 01, 2015 at 08:32:55PM -0400, Stefan Berger wrote:
> >>>>This patch adds the missing common SSDT TPM file.
> >>>>
> >>>>Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> >>>I posted this too. But we really should just get rid of all this: we
> >>>have already removed most ASL code except for the DSDT.
> >>Yes, I will do that. Though for reviewing I think ASL is still easier to
> >>understand.
> >>
> >>   Stefan
> >A bit, but once you get into more trickery, like you do with ifdefs
> >with QEMU-external TPM, it becomes less clear.
> >
> 
> Those won't go away and will turn into case statements in C...
> 
>     stefan

Absolutely but case statements are easier to follow
than ifdef tricks.

-- 
MST