From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YzmIP-0000Ua-71
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:31:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YzmIK-000449-4P
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:31:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50575)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YzmIJ-000442-W6
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:31:52 -0400
Date: Tue, 2 Jun 2015 15:31:48 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150602153044-mutt-send-email-mst@redhat.com>
References: <1433205175-1255386-1-git-send-email-stefanb@linux.vnet.ibm.com>
	<20150602084729-mutt-send-email-mst@redhat.com>
	<556DAC35.10307@linux.vnet.ibm.com>
	<20150602151740-mutt-send-email-mst@redhat.com>
	<556DAE57.3060606@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <556DAE57.3060606@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] tpm: Add missing common TPM SSDT file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanb@us.ibm.com

On Tue, Jun 02, 2015 at 09:23:35AM -0400, Stefan Berger wrote:
> On 06/02/2015 09:22 AM, Michael S. Tsirkin wrote:
> >On Tue, Jun 02, 2015 at 09:14:29AM -0400, Stefan Berger wrote:
> >>On 06/02/2015 02:48 AM, Michael S. Tsirkin wrote:
> >>>On Mon, Jun 01, 2015 at 08:32:55PM -0400, Stefan Berger wrote:
> >>>>This patch adds the missing common SSDT TPM file.
> >>>>
> >>>>Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> >>>I posted this too. But we really should just get rid of all this: we
> >>>have already removed most ASL code except for the DSDT.
> >>Yes, I will do that. Though for reviewing I think ASL is still easier to
> >>understand.
> >>
> >>   Stefan
> >A bit, but once you get into more trickery, like you do with ifdefs
> >with QEMU-external TPM, it becomes less clear.
> >
> 
> Those won't go away and will turn into case statements in C...
> 
>     stefan

Absolutely but case statements are easier to follow
than ifdef tricks.

-- 
MST