From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z05CV-00028q-8z
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 05:43:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z05CP-0006Yw-Pp
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 05:43:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49509)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z05CP-0006Yi-LA
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 05:43:01 -0400
Date: Wed, 3 Jun 2015 10:42:59 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150603094259.GB17548@stefanha-thinkpad.redhat.com>
References: <1432800194-1192-1-git-send-email-thibaut.collet@6wind.com>
	<20150529131209.GJ8598@stefanha-thinkpad.redhat.com>
	<CABUUfwPx9pwbJdTH8KSP8HQBVpV_=2AhQ2LrHHtWsRkd=yYy5w@mail.gmail.com>
	<20150602103429.GF23987@stefanha-thinkpad.redhat.com>
	<CABUUfwNfeuSQKDX-maAfOJMMJwZjHWbTWj9Dzr3X9Y4UtCXD1Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="EuxKj2iCbKjpUGkD"
Content-Disposition: inline
In-Reply-To: <CABUUfwNfeuSQKDX-maAfOJMMJwZjHWbTWj9Dzr3X9Y4UtCXD1Q@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thibaut Collet <thibaut.collet@6wind.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>, Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>, Giuseppe Lettieri <g.lettieri@iet.unipi.it>, Luigi Rizzo <rizzo@iet.unipi.it>


--EuxKj2iCbKjpUGkD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 03, 2015 at 09:56:57AM +0200, Thibaut Collet wrote:
> thanks for your point, I did not notice the problem of the lost of ARP
> announce by discarding the message.
> So I must rewrite my patch to define a queue to transmit the ARP announce
> to the guest. Is it the proper solution?

I'm not sure if vhost-user is designed to support live migration in the
first place.  It's only worth adding ARP packet injection support if
live migration is supported with vhost-user.

You don't need to define a queue, instead implement the .receive()
function for vhost-user and invoke a new virtio-net-specific vhost-user
request type that injects a packet (independent of the tx virtqueue).

Stefan

--EuxKj2iCbKjpUGkD
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVbswjAAoJEJykq7OBq3PICV8IALZbB/UvvjJLCvJt1uNrSIRS
HY/V6oLVOkdV9E8uaL8W2+ZIcU6SD5o7xVTdmzW3Vbi2UfgpDZ/Ybn2mLi0Aycgb
QnQVY9Uo5PgB1PoQ/+EaJkgjjuxMj6T0lf2DAADDs5A5yEGsgR457BCTomd+1WJi
YUrzt5KNcI6UWVa41mCwOuAadnzZoH25I9nL3FmYcvEshaB6Ml8BEPWBUZQlvhmK
rVS7uO819ktxm6NLkkokexXUwf6O3mqx0m0m+v676Z0UUgcVy8THKkthET2mFu1s
JjsyXWWa07Su8s/0bN4+EvCw+TSVLqbkcK29j3FagB6raY1/f7N6765UuJQZTQ4=
=wgBr
-----END PGP SIGNATURE-----

--EuxKj2iCbKjpUGkD--