From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z067N-0004vC-Q6
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 06:41:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z067M-0008Sj-M2
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 06:41:53 -0400
Date: Wed, 3 Jun 2015 11:32:58 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150603103258.GE17548@stefanha-thinkpad.redhat.com>
References: <cover.1432037840.git.berto@igalia.com>
	<d0fdc6978692156725b97bac7cdde88f7b774b84.1432037840.git.berto@igalia.com>
	<20150529123245.GB8598@stefanha-thinkpad.redhat.com>
	<w51iobbika2.fsf@maestria.local.igalia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Lb0e7rgc7IsuDeGj"
Content-Disposition: inline
In-Reply-To: <w51iobbika2.fsf@maestria.local.igalia.com>
Subject: Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: expand test 093 to
 support group throttling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org


--Lb0e7rgc7IsuDeGj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 29, 2015 at 03:29:57PM +0200, Alberto Garcia wrote:
> On Fri 29 May 2015 02:32:45 PM CEST, Stefan Hajnoczi <stefanha@gmail.com>=
 wrote:
>=20
> >>      def setUp(self):
> >> -        self.vm =3D iotests.VM().add_drive(self.test_img)
> >> +        self.vm =3D iotests.VM()
> >> +        for i in range(0, self.max_drives):
> >> +            self.vm.add_drive(self.test_img)
> >
> > Unique files are required, it's not safe to write to open the same
> > image file for writing multiple times.
>=20
> But there's no file here, self.test_img is null-aio://

You are right.  ThrottleTestCase is only used in this file so there's
little danger of setUp() getting called with actual files.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--Lb0e7rgc7IsuDeGj
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVbtfaAAoJEJykq7OBq3PIJv4H/0Hm2jqyBAf23J/8Q+fhwtIm
09ly717EQK8cBpb8VvVuxSFAIa4cZ7R2oUTxZMLp/bWTmYDKIRFQFVRtQdgtkWVt
CCEOMbJ2nF8YKnGc34ayt7BXWUYm7jjTr6ape29d3/W39SsRkUJ18bOz1E6UCY52
f5+SMk5WdJ5YrRH29uu0bmAQfMFPegFBvUkfmsa4NrQ3jhbaTJKD0ghTK5uZQwIq
BNxItR+dlfft8u5b14UQMNhD2Xg/Ad9rYx6S4hVBV7Zg25vx27BJtj9CBUcd3Yl2
HOpfgw/vD6+7s2/7+vp0HUthyL9cZkL9cK47zQF7ypkTxW2QbZCK82cD4FEfFQg=
=P3pj
-----END PGP SIGNATURE-----

--Lb0e7rgc7IsuDeGj--