From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z08v2-00016l-3h for qemu-devel@nongnu.org; Wed, 03 Jun 2015 09:41:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z08ux-0005fZ-4b for qemu-devel@nongnu.org; Wed, 03 Jun 2015 09:41:20 -0400 Date: Wed, 3 Jun 2015 14:41:11 +0100 From: Stefan Hajnoczi Message-ID: <20150603134111.GA20862@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v8 0/8] Block Throttle Group Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2015 at 03:24:28PM +0300, Alberto Garcia wrote: > The previous series no longer applies after all the code that was > moved to block/io.c in 61007b316c, so I rebased it. >=20 > Other than that there are no changes. >=20 > V8: > - Rebased against the current master. >=20 > V7: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg01196.html > - Make block_set_io_throttle() keep a device in the same group if the > parameter is omitted, and rewrite the code a bit to make it clearer > and slightly more efficient. >=20 > - Update the documentation of block_set_io_throttle() to explain in > detail how it works. >=20 > - Improve the iotest 093 to test scenarios with several devices in the > same group. >=20 > - Update version number to 2.4 in the 'Since:' fields. >=20 >=20 > V6: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg06036.html > - Use qemu_init_main_loop() in the throttling tests to make sure that > all BDS have an AioContext attached. >=20 >=20 > V5: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05990.html > - Fixed and expanded the tests. There's a new one that checks that > configuration changes affect the whole throttling group. >=20 > - Refactored the code a bit: new function schedule_next_request() >=20 > - any_timer_armed is now reset in throttle_group_config(), it was > causing qemu-iotest 093 to fail. >=20 > - Documentation improvements >=20 >=20 > V4: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05558.html > - All functions from the ThrottleGroup API now receive a BlockDriverState. >=20 > - The creation/destruction of ThrottleTimers is now handled internally. >=20 > - bdrv_io_limits_enable() no longer accepts NULL as a valid group name. >=20 > - No member of a group can access someone else's throttled_reqs queues > anymore. >=20 > - No member of a group can access someone else's timers unless they > have queued requests. >=20 > - After a timer is fired make sure that there was actually a request > in the queue, and schedule a new one otherwise. >=20 > - Protect bdrv_swap() by locking the throttling group. >=20 > - throttle_group_co_io_limits_intercept() is now marked as a coroutine > function. >=20 > - Documentation updates. >=20 > Regards, >=20 > Berto >=20 > Alberto Garcia (7): > throttle: Add throttle group infrastructure > throttle: Add throttle group infrastructure tests > throttle: Add throttle group support > throttle: acquire the ThrottleGroup lock in bdrv_swap() > throttle: add the name of the ThrottleGroup to BlockDeviceInfo > throttle: Update throttle infrastructure copyright > qemu-iotests: expand test 093 to support group throttling >=20 > Beno=EEt Canet (1): > throttle: Extract timers from ThrottleState into a separate structure >=20 > block.c | 38 ++- > block/Makefile.objs | 1 + > block/io.c | 71 ++---- > block/qapi.c | 8 +- > block/throttle-groups.c | 496 ++++++++++++++++++++++++++++++++++= ++++++ > blockdev.c | 38 ++- > hmp.c | 10 +- > include/block/block.h | 3 +- > include/block/block_int.h | 7 +- > include/block/throttle-groups.h | 46 ++++ > include/qemu/throttle.h | 46 ++-- > qapi/block-core.json | 29 ++- > qemu-options.hx | 1 + > qmp-commands.hx | 3 +- > tests/qemu-iotests/093 | 93 +++++--- > tests/test-throttle.c | 161 +++++++++---- > util/throttle.c | 81 ++++--- > 17 files changed, 927 insertions(+), 205 deletions(-) > create mode 100644 block/throttle-groups.c > create mode 100644 include/block/throttle-groups.h >=20 > --=20 > 2.1.4 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVbwP3AAoJEJykq7OBq3PIotgIAJwjFpyYzJV9oEbba4/ZgDN9 cKKs9LAdTU1Rp2MqDFJxtEQtrWMkIaT71sZJTr5J+ERIQqwLuldPBB0ekUMeFRxp OVAgIqqXXv4pd+KyJVWhV/upqPbxKmZvpTvN4wW7s0RYTrpcSlqiGUDqgFfhwmhq qRHNN13LkwaNJYu/1FVI6aZdon1WwpKHGu442fs7X91A9qU57VDBXkzhYB33uYRq Pk2QP2My/QD5LILj31DDMFqWnsbxIbjiyJpwDTi/vHFmgcGgpwkm6om+FYG3YQDz EE16Dc40OXHsC0WpXHG3QLCDbtcyHXR9X9gMS0ZYFDhiAh9DuxMZPRbnRGGgHpc= =DI7d -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--