[Qemu-devel] virtio branch rebased

[Qemu-devel] virtio branch rebased

[Gerd Hoffmann]

  Hi,

Current state is here:
  https://www.kraxel.org/cgit/qemu/log/?h=rebase/virtio-wip

Still needs some more checkpatch cleanup, build testing and review.
Will continue with that tomorrow.  s390 bits dropped due to conflicts.

Even though this is WIP I accept suggestions for changes in case anyone
finds time to look at this.

cheers,
  Gerd

Re: [Qemu-devel] virtio branch rebased

[Michael S. Tsirkin]

On Wed, Jun 03, 2015 at 05:47:15PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> Current state is here:
>   https://www.kraxel.org/cgit/qemu/log/?h=rebase/virtio-wip
> 
> Still needs some more checkpatch cleanup, build testing and review.
> Will continue with that tomorrow.  s390 bits dropped due to conflicts.
> 
> Even though this is WIP I accept suggestions for changes in case anyone
> finds time to look at this.
> 
> cheers,
>   Gerd
> 

Thanks a million for looking at this.

I looked at it quickly in github, and it looks nice and clean.
If you feel some of this is ready, please post it.

comments:

virtio-pci: add flags to enable/disable legacy/modern
	please change so by default modern is off, legacy is on (can be
	a patch on top too).  There are several spec compliance issues we need
	to address, it'll be cleaner without.

virtio-balloon: virtio 1 support
	should be dropped, the stats struct now looks the
	same for modern and legacy

-- 
MST

Re: [Qemu-devel] virtio branch rebased

[Gerd Hoffmann]

  Hi,

> > Current state is here:
> >   https://www.kraxel.org/cgit/qemu/log/?h=rebase/virtio-wip

Branch updated.

> comments:
> 
> virtio-pci: add flags to enable/disable legacy/modern
> 	please change so by default modern is off, legacy is on (can be
> 	a patch on top too).  There are several spec compliance issues we need
> 	to address, it'll be cleaner without.

Done.

> virtio-balloon: virtio 1 support
> 	should be dropped, the stats struct now looks the
> 	same for modern and legacy

Done.

Also cherry-picked some virtio-pci commits from my vga branch, partly
cleanups and partly stuff I need for virtio-vga.

Branch survived a very light smoke test.
Going to port over virtio-gpu bits and do some more testing now.
Will post series once this has been tested more.
Early reviews comments are welcome nevertheless.

cheers
  Gerd

Re: [Qemu-devel] virtio branch rebased

[Michael S. Tsirkin]

On Thu, Jun 04, 2015 at 11:05:00AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > > Current state is here:
> > >   https://www.kraxel.org/cgit/qemu/log/?h=rebase/virtio-wip
> 
> Branch updated.
> 
> > comments:
> > 
> > virtio-pci: add flags to enable/disable legacy/modern
> > 	please change so by default modern is off, legacy is on (can be
> > 	a patch on top too).  There are several spec compliance issues we need
> > 	to address, it'll be cleaner without.
> 
> Done.
> 
> > virtio-balloon: virtio 1 support
> > 	should be dropped, the stats struct now looks the
> > 	same for modern and legacy
> 
> Done.
> 
> Also cherry-picked some virtio-pci commits from my vga branch, partly
> cleanups and partly stuff I need for virtio-vga.
> 
> Branch survived a very light smoke test.
> Going to port over virtio-gpu bits and do some more testing now.
> Will post series once this has been tested more.

I think it's best to post early, this will give more people a chance to
test it.  E.g. I intend to test it too.  We also need to work on
converting more devices, so far it's only net and balloon.  Just remind
me in the cover letter to defer merging until there's more reports about
testing.

> Early reviews comments are welcome nevertheless.
> 
> cheers
>   Gerd
>