From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RESEND v1 8/8] target-microblaze: Remove dead code
Date: Fri, 5 Jun 2015 10:48:30 +1000 [thread overview]
Message-ID: <20150605004830.GW17878@toto> (raw)
In-Reply-To: <e1cf24a77d0d3ad134ad55dcb8be0b391b57b30e.1433314301.git.alistair.francis@xilinx.com>
On Thu, Jun 04, 2015 at 11:25:49AM +1000, Alistair Francis wrote:
> This code is already being run in the mb_cpu_realizefn()
> function. As PVR registers are preserved on reset this
> code is not required.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> target-microblaze/cpu.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 329d4d5..437250d 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -129,10 +129,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
>
> env->sregs[SR_PC] = cpu->cfg.base_vectors;
>
> -#if defined(CONFIG_USER_ONLY)
> - env->pvr.regs[10] = 0x0c000000; /* Spartan 3a dsp. */
> -#endif
> -
> mcc->parent_realize(dev, errp);
> }
>
> --
> 1.7.1
>
next prev parent reply other threads:[~2015-06-05 0:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 6:56 [Qemu-devel] [PATCH v1 0/8] Extend Microblaze Properties Alistair Francis
2015-06-03 6:58 ` [Qemu-devel] [PATCH v1 3/8] target-microblaze: Convert endi to a CPU property Alistair Francis
2015-06-05 0:37 ` [Qemu-devel] [PATCH RESEND " Edgar E. Iglesias
2015-06-05 0:40 ` Edgar E. Iglesias
2015-06-05 2:21 ` Alistair Francis
2015-06-03 6:59 ` [Qemu-devel] [PATCH v1 4/8] target-microblaze: Convert version_mask " Alistair Francis
2015-06-05 0:42 ` [Qemu-devel] [PATCH RESEND " Edgar E. Iglesias
2015-06-05 2:51 ` Alistair Francis
2015-06-05 2:53 ` Alistair Francis
2015-06-05 2:54 ` Edgar E. Iglesias
2015-06-05 3:20 ` Alistair Francis
2015-06-03 6:59 ` [Qemu-devel] [PATCH v1 5/8] target-microblaze: Convert pvr-full " Alistair Francis
2015-06-05 0:44 ` [Qemu-devel] [PATCH RESEND " Edgar E. Iglesias
2015-06-05 3:00 ` Alistair Francis
2015-06-03 7:00 ` [Qemu-devel] [PATCH v1 6/8] ml605_mmu: Move the hardcoded values to the init function Alistair Francis
2015-06-05 0:47 ` [Qemu-devel] [PATCH RESEND " Edgar E. Iglesias
2015-06-05 4:54 ` Alistair Francis
2015-06-03 7:01 ` [Qemu-devel] [PATCH v1 7/8] s3adsp1800: Remove the hardcoded values from the reset Alistair Francis
2015-06-05 0:47 ` [Qemu-devel] [PATCH RESEND " Edgar E. Iglesias
2015-06-03 7:01 ` [Qemu-devel] [PATCH v1 8/8] target-microblaze: Remove dead code Alistair Francis
2015-06-05 0:48 ` Edgar E. Iglesias [this message]
2015-06-05 0:28 ` [Qemu-devel] [PATCH RESEND v1 2/8] target-microblaze: Convert dcache-writeback to a CPU property Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605004830.GW17878@toto \
--to=edgar.iglesias@xilinx.com \
--cc=alistair.francis@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).