From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1Z0liX-0005QB-2p
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 03:07:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1Z0liT-0006bL-PB
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 03:07:01 -0400
Received: from e28smtp02.in.ibm.com ([122.248.162.2]:35555)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1Z0liT-0006am-4t
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 03:06:57 -0400
Received: from /spool/local
	by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Fri, 5 Jun 2015 12:36:51 +0530
Date: Fri, 5 Jun 2015 12:36:31 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20150605070630.GB25832@in.ibm.com>
References: <1433478358-993-1-git-send-email-bharata@linux.vnet.ibm.com>
	<1433478358-993-5-git-send-email-bharata@linux.vnet.ibm.com>
	<55713D2C.8040503@ozlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55713D2C.8040503@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation
	code
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: thuth@redhat.com, mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, david@gibson.dropbear.id.au

On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote:
> >
> >-        ret = fdt_setprop(fdt, offset, "ibm,pft-size",
> >-                          pft_size_prop, sizeof(pft_size_prop));
> 
> You broke formatting here, above 8 lines should not be in the patch.

You mean above 80 chars ? It is not above 80 chars.

> >+    _FDT((fdt_setprop_cell(fdt, offset, "d-cache-block-size",
> >+                            env->dcache_line_size)));
> 
> Wrong indent.

checkpatch.pl doesn't complain, but should we start the second line
below ( of the first line ?

Regards,
Bharata.