From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
Cc: qemu-block@nongnu.org,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] block-backend: Introduce blk_drain() and replace blk_drain_all()
Date: Mon, 8 Jun 2015 13:03:12 +0200 [thread overview]
Message-ID: <20150608110312.GB5954@noname.redhat.com> (raw)
In-Reply-To: <1433339175-12300-2-git-send-email-yarygin@linux.vnet.ibm.com>
Am 03.06.2015 um 15:46 hat Alexander Yarygin geschrieben:
> Each call of the virtio_blk_reset() function calls blk_drain_all(),
> which works for all existing BlockDriverStates, while only one
> BlockDriverState needs to be drained.
>
> This patch introduces the blk_drain() function and replaces
> blk_drain_all() on it in virtio_blk_reset().
>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
For the BlockBackend part:
Acked-by: Kevin Wolf <kwolf@redhat.com>
The only thing that I could suggest is that if you respin, it would be
cleaner to split this into two parts (as small as they may be). That you
have an "and" in your subject line is a strong hint for this.
Kevin
next prev parent reply other threads:[~2015-06-08 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 13:46 [Qemu-devel] [PATCH RFC 0/2] Fix slow startup with many disks Alexander Yarygin
2015-06-03 13:46 ` [Qemu-devel] [PATCH 1/2] block-backend: Introduce blk_drain() and replace blk_drain_all() Alexander Yarygin
2015-06-03 13:57 ` Paolo Bonzini
2015-06-03 14:07 ` Christian Borntraeger
2015-06-08 7:36 ` Christian Borntraeger
2015-06-08 9:11 ` Stefan Hajnoczi
2015-06-08 11:03 ` Kevin Wolf [this message]
2015-06-10 10:07 ` Fam Zheng
2015-06-03 13:46 ` [Qemu-devel] [PATCH 2/2] block: Let bdrv_drain_all() to call aio_poll() for each AioContext Alexander Yarygin
2015-06-03 14:11 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608110312.GB5954@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tumanova@linux.vnet.ibm.com \
--cc=yarygin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).