qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Frediano Ziglio <fziglio@redhat.com>
Cc: spice-devel@lists.freedesktop.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] RFC: qxl: allow to specify head limit to qxl driver
Date: Tue, 9 Jun 2015 10:50:48 +0100	[thread overview]
Message-ID: <20150609095047.GE2089@redhat.com> (raw)
In-Reply-To: <1433839784-5634-1-git-send-email-fziglio@redhat.com>

On Tue, Jun 09, 2015 at 09:49:44AM +0100, Frediano Ziglio wrote:
> This patch allow to limit number of heads using qxl driver. By default
> qxl driver is not limited on any kind on head use so can decide to use
> as much heads.
> 
> libvirt has this as a video card parameter (actually set to 1 but not
> used). This parameter will allow to limit setting a use can do (which
> could be confusing).
> 
> This patch rely on some change in spice-protocol which are not still
> accepted. See
> http://lists.freedesktop.org/archives/spice-devel/2015-June/020160.html.
> 
> Main question and stop over are parameter name. Consider that this
> parameter is actually more a hint to drivers. I'm looking anyway to
> a way to enforce this in spice-server.

What is the actual benefit of being able to limit the number of
heads in QXL / SPICE ?

I know libvirt has the 'heads' attribute for specifying the number
of video outputs. This is used in hypervisors which only support a
fixed number of outputs and need up-front configuration. Since
QXL/SPICE can dynamically enable/disable heads, there is no need to
support this libvirt configuration attribute - it is better from a
usability POV to have the head count totally dynamic, than to add
a fixed limit.

IOW, unless there's some need to use this limit in order to go
above the 16 head maximum the code currently has, I think adding
this manual limit to QXL/SPICE is a step backwards really. It
feels like a feature in search of a purpose IMHO.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  parent reply	other threads:[~2015-06-09  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  8:49 [Qemu-devel] [PATCH] RFC: qxl: allow to specify head limit to qxl driver Frediano Ziglio
2015-06-09  9:12 ` Gerd Hoffmann
2015-06-09  9:26   ` Frediano Ziglio
2015-06-09  9:43     ` Gerd Hoffmann
2015-06-09 15:03       ` Frediano Ziglio
2015-06-09  9:50 ` Daniel P. Berrange [this message]
2015-06-09 11:15   ` [Qemu-devel] [Spice-devel] " Christophe Fergeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609095047.GE2089@redhat.com \
    --to=berrange@redhat.com \
    --cc=fziglio@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=spice-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).