From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, eharney@redhat.com,
stefanha@redhat.com, crobinso@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size
Date: Tue, 9 Jun 2015 16:25:36 +0100 [thread overview]
Message-ID: <20150609152536.GD3181@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1433840108-9996-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Tue, Jun 09, 2015 at 10:55:08AM +0200, Kevin Wolf wrote:
> Image files with an unaligned image size have a final hole that starts
> at EOF, i.e. in the middle of a sector. Currently, *pnum == 0 is
> returned when checking the status of this sector. In qemu-img, this
> triggers an assertion failure.
>
> In order to fix this, one type for the sector that contains EOF must be
> found. Treating a hole as data is safe, so this patch rounds the
> calculated number of data sectors up, so that a partial sector at EOF is
> treated as a full data sector.
>
> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1229394
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/raw-posix.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-06-09 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 8:55 [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size Kevin Wolf
2015-06-09 9:47 ` Wen Congyang
2015-06-09 9:49 ` Kevin Wolf
2015-06-09 10:11 ` Wen Congyang
2015-06-09 11:36 ` Eric Blake
2015-06-09 14:14 ` Cole Robinson
2015-06-09 15:25 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609152536.GD3181@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=crobinso@redhat.com \
--cc=eharney@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).