Re: [Qemu-devel] [PATCH v3 1/2] ACPI: Add definitions for the SPCR table

[Igor Mammedov <imammedo@redhat.com>]

On Wed, 10 Jun 2015 05:52:38 -0400
Andrew Jones <drjones@redhat.com> wrote:

> SPCR is the Serial Port Console Redirection Table. See the document
> linked from http://uefi.org/acpi. For serial port types, "Interface
> Type", see the documentation for the Debug Port Table 2 (DBG2).
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> Tested-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  include/hw/acpi/acpi-defs.h | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h
> index 59cf277434b37..7b4bfb7494717 100644
> --- a/include/hw/acpi/acpi-defs.h
> +++ b/include/hw/acpi/acpi-defs.h
> @@ -197,6 +197,38 @@ enum {
>  };
>  
>  /*
> + * Serial Port Console Redirection Table (SPCR), Rev. 1.02
> + *
> + * For .interface_type see Debug Port Table 2 (DBG2) serial port
> + * subtypes in Table 3, Rev. May 22, 2012
> + */
> +struct AcpiSerialPortConsoleRedirection {
> +    ACPI_TABLE_HEADER_DEF
> +    uint8_t  interface_type;
> +    uint8_t  reserved1[3];
> +    struct AcpiGenericAddress base_address;
> +    uint8_t  interrupt_types;
> +    uint8_t  irq;
> +    uint32_t gsi;
> +    uint8_t  baud;
> +    uint8_t  parity;
> +    uint8_t  stopbits;
> +    uint8_t  flowctrl;
> +    uint8_t  term_type;
> +    uint8_t  reserved2;
> +    uint16_t pci_device_id;
> +    uint16_t pci_vendor_id;
> +    uint8_t  pci_bus;
> +    uint8_t  pci_slot;
> +    uint8_t  pci_func;
> +    uint32_t pci_flags;
> +    uint8_t  pci_seg;
> +    uint32_t reserved3;
> +} QEMU_PACKED;
> +typedef struct AcpiSerialPortConsoleRedirection
> +               AcpiSerialPortConsoleRedirection;
> +
> +/*
>   * ACPI 1.0 Root System Description Table (RSDT)
>   */
>  struct AcpiRsdtDescriptorRev1