From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2wbk-0002rE-K5 for qemu-devel@nongnu.org; Thu, 11 Jun 2015 03:09:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2wbg-0004Nr-57 for qemu-devel@nongnu.org; Thu, 11 Jun 2015 03:09:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2wbf-0004Nl-Vn for qemu-devel@nongnu.org; Thu, 11 Jun 2015 03:08:56 -0400 Date: Thu, 11 Jun 2015 09:08:53 +0200 From: Igor Mammedov Message-ID: <20150611090853.2952986d@nial.brq.redhat.com> In-Reply-To: <1433929959-29530-2-git-send-email-drjones@redhat.com> References: <1433929959-29530-1-git-send-email-drjones@redhat.com> <1433929959-29530-2-git-send-email-drjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/2] ACPI: Add definitions for the SPCR table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: peter.maydell@linaro.org, shannon.zhao@linaro.org, qemu-devel@nongnu.org, mst@redhat.com On Wed, 10 Jun 2015 05:52:38 -0400 Andrew Jones wrote: > SPCR is the Serial Port Console Redirection Table. See the document > linked from http://uefi.org/acpi. For serial port types, "Interface > Type", see the documentation for the Debug Port Table 2 (DBG2). > > Signed-off-by: Andrew Jones > Tested-by: Shannon Zhao Reviewed-by: Igor Mammedov > --- > include/hw/acpi/acpi-defs.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h > index 59cf277434b37..7b4bfb7494717 100644 > --- a/include/hw/acpi/acpi-defs.h > +++ b/include/hw/acpi/acpi-defs.h > @@ -197,6 +197,38 @@ enum { > }; > > /* > + * Serial Port Console Redirection Table (SPCR), Rev. 1.02 > + * > + * For .interface_type see Debug Port Table 2 (DBG2) serial port > + * subtypes in Table 3, Rev. May 22, 2012 > + */ > +struct AcpiSerialPortConsoleRedirection { > + ACPI_TABLE_HEADER_DEF > + uint8_t interface_type; > + uint8_t reserved1[3]; > + struct AcpiGenericAddress base_address; > + uint8_t interrupt_types; > + uint8_t irq; > + uint32_t gsi; > + uint8_t baud; > + uint8_t parity; > + uint8_t stopbits; > + uint8_t flowctrl; > + uint8_t term_type; > + uint8_t reserved2; > + uint16_t pci_device_id; > + uint16_t pci_vendor_id; > + uint8_t pci_bus; > + uint8_t pci_slot; > + uint8_t pci_func; > + uint32_t pci_flags; > + uint8_t pci_seg; > + uint32_t reserved3; > +} QEMU_PACKED; > +typedef struct AcpiSerialPortConsoleRedirection > + AcpiSerialPortConsoleRedirection; > + > +/* > * ACPI 1.0 Root System Description Table (RSDT) > */ > struct AcpiRsdtDescriptorRev1