From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z36kv-0001VW-Gk for qemu-devel@nongnu.org; Thu, 11 Jun 2015 13:59:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z36ks-00006q-IQ for qemu-devel@nongnu.org; Thu, 11 Jun 2015 13:59:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z36ks-00006k-DU for qemu-devel@nongnu.org; Thu, 11 Jun 2015 13:59:06 -0400 Date: Thu, 11 Jun 2015 13:53:00 -0400 From: Luiz Capitulino Message-ID: <20150611135300.4274b0ab@redhat.com> In-Reply-To: <20150528155412.18341ee7@redhat.com> References: <1431728700-18055-1-git-send-email-eblake@redhat.com> <20150528155412.18341ee7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Use bool for QBool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, berto@igalia.com, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, mdroth@linux.vnet.ibm.com, mreitz@redhat.com, afaerber@suse.de On Thu, 28 May 2015 15:54:12 -0400 Luiz Capitulino wrote: > On Fri, 15 May 2015 16:24:58 -0600 > Eric Blake wrote: > > > Passing around an 'int' for a QBool type is weird, when we already > > use a C99 compiler and have a sane 'bool' that does just fine. > > > > I half-debated sending this through qemu-trivial, but think it > > better belongs through the QMP tree. There turned out to be few > > enough clients that I grouped it into two patches touching a number > > of files each; but I'm also okay with splitting into finer-grained > > patches that focus on fewer files at a time if that is desired. > > > > Eric Blake (2): > > qobject: Use 'bool' for qbool > > qobject: Use 'bool' inside qdict > > Applied to the qmp branch, thanks. Unfortunately, I'm quite busy and won't have time to push this through my tree. Markus is going to pick up this series soon. Acked-by: Luiz Capitulino > > > > > block/qapi.c | 2 +- > > block/quorum.c | 4 ++-- > > block/vvfat.c | 4 ++-- > > hmp.c | 40 ++++++++++++++++++++-------------------- > > hw/pci/pcie_aer.c | 4 ++-- > > include/qapi/qmp/qbool.h | 8 ++++---- > > include/qapi/qmp/qdict.h | 4 ++-- > > monitor.c | 12 ++++++------ > > qapi/qmp-input-visitor.c | 2 +- > > qapi/qmp-output-visitor.c | 2 +- > > qobject/json-parser.c | 6 +++--- > > qobject/qbool.c | 8 ++++---- > > qobject/qdict.c | 8 ++++---- > > qobject/qjson.c | 2 +- > > qom/object.c | 4 ++-- > > tests/check-qjson.c | 11 ++++++----- > > tests/test-qmp-event.c | 4 ++-- > > tests/test-qmp-output-visitor.c | 6 +++--- > > util/qemu-option.c | 2 +- > > 19 files changed, 67 insertions(+), 66 deletions(-) > > >