From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Z36kv-0001VV-Fz
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 13:59:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Z36kt-00007c-Ps
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 13:59:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60735)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Z36kt-00007Y-Kw
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 13:59:07 -0400
Date: Thu, 11 Jun 2015 13:53:56 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20150611135356.6ab8d26f@redhat.com>
In-Reply-To: <20150528161841.72032284@redhat.com>
References: <1431948138-14238-1-git-send-email-hw.claudio@gmail.com>
	<20150528161841.72032284@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v6 0/2] monitor: add memory search commands s,
	sp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: hw.claudio@gmail.com
Cc: Peter Maydell <peter.maydell@linaro.org>, Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, 28 May 2015 16:18:41 -0400
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Mon, 18 May 2015 13:22:16 +0200
> hw.claudio@gmail.com wrote:
> 
> > From: Claudio Fontana <claudio.fontana@huawei.com>
> > 
> > This is the latest iteration of the memory search patch,
> > including a trivial replacement for the memmem function for systems
> > which don't provide one (notably Windows).
> > 
> > It detects the presence of memmem in configure and sets CONFIG_MEMMEM,
> > providing a trivial implementation for the !CONFIG_MEMMEM case.
> > 
> > The new code is MIT licensed, following usage of other files in the same
> > directory dealing with replacement functions (osdep, oslib, getauxval etc),
> > and to maximize reusability.
> > 
> > I have tested this in both CONFIG_MEMMEM defined/undefined scenarios,
> > but more feedback and testing is welcome of course.
> > 
> > changes from v5:
> > dropped the import from gnulib and implemented a trivial replacement.
> > 
> > changes from v4:
> > made into a series of two patches.
> > Introduced a memmem replacement function (import from gnulib)
> > and detection code in configure.
> > 
> > changes from v3:
> > initialize pointer variable to NULL to finally get rid of spurious warning
> > 
> > changes from v2:
> > move code to try to address spurious warning
> > 
> > changes from v1:
> > make checkpatch happy by adding braces here and there.
> > 
> > 
> > Claudio Fontana (2):
> >   util: add memmem replacement function
> >   monitor: add memory search commands s, sp
> 
> Applied to the qmp branch, thanks.


Unfortunately, I'm quite busy and won't have time to push this
through my tree. Markus is going to pick up this series soon.

Acked-by: Luiz Capitulino <lcapitulino@redhat.com>

> 
> > 
> >  configure            |  15 ++++++
> >  hmp-commands.hx      |  28 +++++++++++
> >  include/qemu/osdep.h |   4 ++
> >  monitor.c            | 140 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  util/Makefile.objs   |   1 +
> >  util/memmem.c        |  62 +++++++++++++++++++++++
> >  6 files changed, 250 insertions(+)
> >  create mode 100644 util/memmem.c
> > 
>