From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z37MX-0004Pj-Et for qemu-devel@nongnu.org; Thu, 11 Jun 2015 14:38:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z37MS-00034g-02 for qemu-devel@nongnu.org; Thu, 11 Jun 2015 14:38:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z37MR-00034c-Qy for qemu-devel@nongnu.org; Thu, 11 Jun 2015 14:37:55 -0400 Date: Thu, 11 Jun 2015 19:37:51 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150611183750.GK2123@work-vm> References: <1434043048-4444-1-git-send-email-dgilbert@redhat.com> <1434043048-4444-5-git-send-email-dgilbert@redhat.com> <5579CBB6.8080604@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5579CBB6.8080604@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 04/12] rdma typos List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: amit.shah@redhat.com, quintela@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, mrhines@us.ibm.com * Michael R. Hines (mrhines@linux.vnet.ibm.com) wrote: > On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > > >A couple of typo fixes. > > > >Signed-off-by: Dr. David Alan Gilbert > >--- > > migration/rdma.c | 6 +++--- > > trace-events | 4 ++-- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > >diff --git a/migration/rdma.c b/migration/rdma.c > >index bc73ff8..44ed996 100644 > >--- a/migration/rdma.c > >+++ b/migration/rdma.c > >@@ -1215,7 +1215,7 @@ const char *print_wrid(int wrid) > > > > /* > > * Perform a non-optimized memory unregistration after every transfer > >- * for demonsration purposes, only if pin-all is not requested. > >+ * for demonstration purposes, only if pin-all is not requested. > > * > > * Potential optimizations: > > * 1. Start a new thread to run this function continuously > >@@ -3279,7 +3279,7 @@ static void rdma_accept_incoming_migration(void *opaque) > > QEMUFile *f; > > Error *local_err = NULL, **errp = &local_err; > > > >- trace_qemu_dma_accept_incoming_migration(); > >+ trace_qemu_rdma_accept_incoming_migration(); > > ret = qemu_rdma_accept(rdma); > > > > if (ret) { > >@@ -3287,7 +3287,7 @@ static void rdma_accept_incoming_migration(void *opaque) > > return; > > } > > > >- trace_qemu_dma_accept_incoming_migration_accepted(); > >+ trace_qemu_rdma_accept_incoming_migration_accepted(); > > > > f = qemu_fopen_rdma(rdma, "rb"); > > if (f == NULL) { > >diff --git a/trace-events b/trace-events > >index 2662ffa..8b468fe 100644 > >--- a/trace-events > >+++ b/trace-events > >@@ -1398,8 +1398,8 @@ migrate_pending(uint64_t size, uint64_t max) "pending size %" PRIu64 " max %" PR > > migrate_transferred(uint64_t tranferred, uint64_t time_spent, double bandwidth, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 " bandwidth %g max_size %" PRId64 > > > > # migration/rdma.c > >-qemu_dma_accept_incoming_migration(void) "" > >-qemu_dma_accept_incoming_migration_accepted(void) "" > >+qemu_rdma_accept_incoming_migration(void) "" > >+qemu_rdma_accept_incoming_migration_accepted(void) "" > > What happened to the actual message inside the quotes? =) You don't need them in most cases; the trace tools normally print the name of the event. Dave > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK