Re: [Qemu-devel] [PATCH v4 0/4] rocker device updates

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2950 bytes --]

On Wed, Jun 10, 2015 at 06:21:17PM -0700, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
> 
> v4:
> 
> Address review comments from Stefan Hajnoczi:
> 
>  - hmp.c: change flow->hits printing to PRIu64 since it's uint64_t
> 
> Address review comments from Eric Blake:
> 
>  - qapi/rocker.txt: fix comments to match commands
>  - qmp-commands.hx: wrap some long comment lines
> 
> v3:
> 
> Address review comments from Stefan Hajnoczi:
> 
>  - Add missing hw/net/rocker/qmp-norocker.c file.
>  - Add missing curly brackets to a for loop
> 
> v2:
> 
> Address some review comments by Stefan Hajnoczi: see individual patches for
> v1->v2 changes.
> 
> v1:
> 
> Some rocker device updates we've been holding onto waiting for base rocker
> device to be pulled into 2.4.  David added support for the device to return the
> physical port name, which in turn can be used by the OS to name the interface.
> I added a small change the bringe link up/down when port is enabled/disabled.
> 
> The big addition is adding qmp/hmp support to rocker.  This was included in the
> original rocker device patch set, but pulled as there where last-minute issues
> with building on non-PCI targets.  These issues have been addressed by stubbing
> out qmp/hmp support when rocker device is built for non-PCI targets.
> 
> 
> David Ahern (1):
>   rocker: Add support for phys name
> 
> Scott Feldman (3):
>   rocker: update tests using hw-derived interface names
>   rocker: bring link up/down on PHY enable/disable
>   qmp/hmp: add rocker device support
> 
>  docs/specs/rocker.txt         |    1 +
>  hmp-commands.hx               |   24 ++++
>  hmp.c                         |  303 +++++++++++++++++++++++++++++++++++++++
>  hmp.h                         |    4 +
>  hw/net/Makefile.objs          |    1 +
>  hw/net/rocker/qmp-norocker.c  |   50 +++++++
>  hw/net/rocker/rocker.c        |   68 ++++++++-
>  hw/net/rocker/rocker_fp.c     |   29 +++-
>  hw/net/rocker/rocker_fp.h     |    2 +
>  hw/net/rocker/rocker_hw.h     |    1 +
>  hw/net/rocker/rocker_of_dpa.c |  312 +++++++++++++++++++++++++++++++++++++++++
>  monitor.c                     |   28 ++++
>  qapi-schema.json              |    3 +
>  qapi/rocker.json              |  286 +++++++++++++++++++++++++++++++++++++
>  qmp-commands.hx               |  103 ++++++++++++++
>  tests/rocker/bridge           |   25 ++--
>  tests/rocker/bridge-stp       |   25 ++--
>  tests/rocker/bridge-vlan      |   37 +++--
>  tests/rocker/bridge-vlan-stp  |   37 +++--
>  tests/rocker/port             |    8 +-
>  20 files changed, 1269 insertions(+), 78 deletions(-)
>  create mode 100644 hw/net/rocker/qmp-norocker.c
>  create mode 100644 qapi/rocker.json

When merging, I added "query-" to the doc comments as requested by Eric
Blake.

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]