From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3OaE-0002Qu-N0 for qemu-devel@nongnu.org; Fri, 12 Jun 2015 09:01:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3OaA-000170-FS for qemu-devel@nongnu.org; Fri, 12 Jun 2015 09:01:18 -0400 Date: Fri, 12 Jun 2015 14:01:10 +0100 From: Stefan Hajnoczi Message-ID: <20150612130110.GA30168@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v9 0/8] Block Throttle Group Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 08, 2015 at 06:17:40PM +0200, Alberto Garcia wrote: > V9: > - Make test-throttle.c call bdrv_init() to make sure that > throttle_groups_init() gets called and the mutex is initialized. > This was breaking the tests in Mac OS X. >=20 > V8: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg03716.html > - Rebased against the current master. >=20 > V7: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg01196.html > - Make block_set_io_throttle() keep a device in the same group if the > parameter is omitted, and rewrite the code a bit to make it clearer > and slightly more efficient. >=20 > - Update the documentation of block_set_io_throttle() to explain in > detail how it works. >=20 > - Improve the iotest 093 to test scenarios with several devices in the > same group. >=20 > - Update version number to 2.4 in the 'Since:' fields. >=20 >=20 > V6: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg06036.html > - Use qemu_init_main_loop() in the throttling tests to make sure that > all BDS have an AioContext attached. >=20 >=20 > V5: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05990.html > - Fixed and expanded the tests. There's a new one that checks that > configuration changes affect the whole throttling group. >=20 > - Refactored the code a bit: new function schedule_next_request() >=20 > - any_timer_armed is now reset in throttle_group_config(), it was > causing qemu-iotest 093 to fail. >=20 > - Documentation improvements >=20 >=20 > V4: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05558.html > - All functions from the ThrottleGroup API now receive a BlockDriverState. >=20 > - The creation/destruction of ThrottleTimers is now handled internally. >=20 > - bdrv_io_limits_enable() no longer accepts NULL as a valid group name. >=20 > - No member of a group can access someone else's throttled_reqs queues > anymore. >=20 > - No member of a group can access someone else's timers unless they > have queued requests. >=20 > - After a timer is fired make sure that there was actually a request > in the queue, and schedule a new one otherwise. >=20 > - Protect bdrv_swap() by locking the throttling group. >=20 > - throttle_group_co_io_limits_intercept() is now marked as a coroutine > function. >=20 > - Documentation updates. >=20 > Regards, >=20 > Berto >=20 > Alberto Garcia (7): > throttle: Add throttle group infrastructure > throttle: Add throttle group infrastructure tests > throttle: Add throttle group support > throttle: acquire the ThrottleGroup lock in bdrv_swap() > throttle: add the name of the ThrottleGroup to BlockDeviceInfo > throttle: Update throttle infrastructure copyright > qemu-iotests: expand test 093 to support group throttling >=20 > Beno=EEt Canet (1): > throttle: Extract timers from ThrottleState into a separate structure >=20 > block.c | 38 ++- > block/Makefile.objs | 1 + > block/io.c | 71 ++---- > block/qapi.c | 8 +- > block/throttle-groups.c | 496 ++++++++++++++++++++++++++++++++++= ++++++ > blockdev.c | 38 ++- > hmp.c | 10 +- > include/block/block.h | 3 +- > include/block/block_int.h | 7 +- > include/block/throttle-groups.h | 46 ++++ > include/qemu/throttle.h | 46 ++-- > qapi/block-core.json | 29 ++- > qemu-options.hx | 1 + > qmp-commands.hx | 3 +- > tests/qemu-iotests/093 | 89 ++++--- > tests/test-throttle.c | 163 +++++++++---- > util/throttle.c | 81 ++++--- > 17 files changed, 927 insertions(+), 203 deletions(-) > create mode 100644 block/throttle-groups.c > create mode 100644 include/block/throttle-groups.h >=20 > --=20 > 2.1.4 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVetgWAAoJEJykq7OBq3PIACEIAK4UTHerJqlf2XgdE5tQai++ bhs7fiM8c33ySSt31B+ysCZBfHoqxC3jX5RxMtjdBlU9GgPKw8WwWM7oqeZ7GdWS vNwL2K+cxzamy6JRC8dnCHp6ieUSROsrtXi+3Pmhd9OyHvDacPm+QLB0yEJRPwvf m7noXe/wOTlyDdUnYMBD7lNhyk7mtf/2aUbP/4cKEjbER+u9N8Z8zlkBSNm8Iuhg usf5K7d0Awd0qIqnMtHPDkI47cgtI+ZamuhreI60J3i3XI7JsjWp8Zg1NFjz6skp OQEcCJkQ3wxSR0Rxqk1ReRlmEimafXaIFw9008q9MsZL+tzPumDQqznxsAU68+w= =qQpz -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--