From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Z3RiB-0003A2-Dg
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 12:21:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Z3Ri6-0003kC-Pl
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 12:21:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Z3Ri6-0003js-K0
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 12:21:38 -0400
Date: Fri, 12 Jun 2015 18:21:35 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20150612182135.63fa688e@nial.brq.redhat.com>
In-Reply-To: <CAFEAcA9r1MpCt-MBk+udGroMH-3iP3k4pQ3BkZjAVA13O=EnRg@mail.gmail.com>
References: <1433153700-1336-1-git-send-email-shannon.zhao@linaro.org>
	<CAFEAcA9r1MpCt-MBk+udGroMH-3iP3k4pQ3BkZjAVA13O=EnRg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH] hw/arm/virt-acpi-build: Add GICv2m
 description in ACPI MADT table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>, Shannon Zhao <shannon.zhao@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

On Fri, 12 Jun 2015 15:55:22 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 1 June 2015 at 11:15,  <shannon.zhao@linaro.org> wrote:
> > From: Shannon Zhao <shannon.zhao@linaro.org>
> >
> > Add GICv2m description in ACPI MADT table, so guest can use MSI when
> > booting with ACPI.
> >
> > Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> > ---
> >     This is based on Christoffer's GICv2m patchset.
> >         Test virtio-net-pci, e1000.
> > ---
> >  hw/arm/virt-acpi-build.c    | 11 +++++++++++
> >  include/hw/acpi/acpi-defs.h | 12 ++++++++++++
> >  2 files changed, 23 insertions(+)
> >
> > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> > index a9373cc..d8dcf45 100644
> > --- a/hw/arm/virt-acpi-build.c
> > +++ b/hw/arm/virt-acpi-build.c
> > @@ -385,8 +385,10 @@ build_madt(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info,
> >  {
> >      int madt_start = table_data->len;
> >      const MemMapEntry *memmap = guest_info->memmap;
> > +    const int *irqmap = guest_info->irqmap;
> >      AcpiMultipleApicTable *madt;
> >      AcpiMadtGenericDistributor *gicd;
> > +    AcpiMadtGenericMsiFrame *gic_msi;
> >      int i;
> >
> >      madt = acpi_data_push(table_data, sizeof *madt);
> > @@ -410,6 +412,15 @@ build_madt(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info,
> >      gicd->length = sizeof(*gicd);
> >      gicd->base_address = memmap[VIRT_GIC_DIST].base;
> >
> > +    gic_msi = acpi_data_push(table_data, sizeof *gic_msi);
> > +    gic_msi->type = ACPI_APIC_GENERIC_MSI_FRAME;
> > +    gic_msi->length = sizeof(*gic_msi);
> > +    gic_msi->gic_msi_frame_id = 0;
> > +    gic_msi->base_address = memmap[VIRT_GIC_V2M].base;
> > +    gic_msi->flags = cpu_to_le32(1);
> > +    gic_msi->spi_count = NUM_GICV2M_SPIS;
> > +    gic_msi->spi_base = irqmap[VIRT_GIC_V2M] + ARM_SPI_BASE;
> 
> Why do we need to convert the flags to little-endian,
> but not the length, base address or other fields?
+1 all ACPI numbers should be converted to little-endian.

> 
> thanks
> -- PMM
>