From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3XBy-0005Xd-FG for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3XBx-0000Gl-HF for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:12:50 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:35000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3XBx-0000Gh-6J for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:12:49 -0400 Date: Sat, 13 Jun 2015 00:12:47 +0200 From: Aurelien Jarno Message-ID: <20150612221247.GA3929@aurel32.net> References: <1433884389-2643-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433884389-2643-1-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 0/3] target-alpha PALcode improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On 2015-06-09 14:13, Richard Henderson wrote: > Rather than copying around a block of 8 registers when we swap modes, > let the translator map code generated for PALmode to the shadow regs > directly. This simplifies PALmode entry and exit sufficiently to > allow these insns to be performed inline. > > Sadly, the speedup for this is in the noise. But I still think it > makes sense. That's usually the case nowadays. It seems all TCG related part are already well optimized, and that most targets are now limited by the MMU emulation. That said I agree it makes sense, and also makes the code cleaner (even if bigger). > > r~ > > > Richard Henderson (3): > target-alpha: Use separate TCGv temporaries for the shadow registers > target-alpha: Inline call_pal > target-alpha: Inline hw_ret > > target-alpha/cpu.h | 3 +- > target-alpha/gdbstub.c | 4 +- > target-alpha/helper.c | 63 ++++++--------- > target-alpha/helper.h | 3 - > target-alpha/machine.c | 4 +- > target-alpha/sys_helper.c | 22 ----- > target-alpha/translate.c | 201 ++++++++++++++++++++++++++++++---------------- > 7 files changed, 166 insertions(+), 134 deletions(-) The whole series is: Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net