From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z46fn-0001p7-Un for qemu-devel@nongnu.org; Sun, 14 Jun 2015 08:06:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z46fk-0004lf-Ox for qemu-devel@nongnu.org; Sun, 14 Jun 2015 08:05:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z46fk-0004k7-By for qemu-devel@nongnu.org; Sun, 14 Jun 2015 08:05:56 -0400 Date: Sun, 14 Jun 2015 14:05:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20150614140322-mutt-send-email-mst@redhat.com> References: <20150611142425.GA10763@morn.localdomain> <55799CD6.1060506@redhat.com> <20150611165404.GB20655@morn.localdomain> <5579C959.8020607@redhat.com> <5579D4D0.6010906@redhat.com> <20150611192427.GB28252@morn.localdomain> <557AA59E.6050509@redhat.com> <20150612130326.GA3622@morn.localdomain> <557AFE80.4040402@redhat.com> <20150612184009.GA3963@morn.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150612184009.GA3963@morn.localdomain> Subject: Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Marcel Apfelbaum , seabios@seabios.org, Laszlo Ersek , Gerd Hoffmann , qemu-devel@nongnu.org On Fri, Jun 12, 2015 at 02:40:10PM -0400, Kevin O'Connor wrote: > > (2) The QEMU command line and the effects the command line has on the > > virtual hardware should not change. However, all of the following have > > to be updated: > > > > - the "explicit_ofw_unit_address" property assignments in > > pxb_dev_initfn() have to be done separately, after all PXBs have been > > seen, and sorted. This probably requires another "machine init done" > > notifier. > > I admit the sorting of pxb objects just to reverse engineer what > SeaBIOS expects would not be fun. Doesn't QEMU have to sort the buses > anyway to know which secondary bus ranges are associated with each > root bus? I guess it can be done - though this means it will break if we ever support hot-plugging of these roots. But more importantly, if the sort is by the bus number, then how is it better than just using the bus number directly? -- MST