From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4PDx-0002rL-LB for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4PDu-0002t9-2N for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:29 -0400 Date: Mon, 15 Jun 2015 16:57:10 +1000 From: David Gibson Message-ID: <20150615065710.GI13352@voom.redhat.com> References: <1433478358-993-1-git-send-email-bharata@linux.vnet.ibm.com> <1433478358-993-5-git-send-email-bharata@linux.vnet.ibm.com> <55713D2C.8040503@ozlabs.ru> <20150605070630.GB25832@in.ibm.com> <557155E8.1020706@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r4QXMf6/kyF/FvJJ" Content-Disposition: inline In-Reply-To: <557155E8.1020706@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH v4 4/8] spapr: Reorganize CPU dt generation code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com --r4QXMf6/kyF/FvJJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 05, 2015 at 05:55:20PM +1000, Alexey Kardashevskiy wrote: > On 06/05/2015 05:06 PM, Bharata B Rao wrote: > >On Fri, Jun 05, 2015 at 04:09:48PM +1000, Alexey Kardashevskiy wrote: > >>> > >>>- ret =3D fdt_setprop(fdt, offset, "ibm,pft-size", > >>>- pft_size_prop, sizeof(pft_size_prop)); > >> > >>You broke formatting here, above 8 lines should not be in the patch. > > > >You mean above 80 chars ? It is not above 80 chars. >=20 > The chunk is: >=20 > + ret =3D fdt_setprop(fdt, offset, "ibm,pft-size", > + pft_size_prop, sizeof(pft_size_prop)); > + if (ret < 0) { > + return ret; > } >=20 > - ret =3D fdt_setprop(fdt, offset, "ibm,pft-size", > - pft_size_prop, sizeof(pft_size_prop)); >=20 >=20 >=20 > pft_size_prop was under "fdt", now it is not, and this is the only change. >=20 >=20 >=20 > > > >>>+ _FDT((fdt_setprop_cell(fdt, offset, "d-cache-block-size", > >>>+ env->dcache_line_size))); > >> > >>Wrong indent. > > > >checkpatch.pl doesn't complain, but should we start the second line > >below ( of the first line ? >=20 > Below "(" plus 1 char right. >=20 > set expandtab, set tabstop=3D4, set shiftwidth=3D4, set cino=3D:0,(0 - t= his is > what I use for QEMU. Again, not a big deal, but I'd like a v2 of the series to address a couple of other things, so you might as well correct the formatting at the same time. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --r4QXMf6/kyF/FvJJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVfndGAAoJEGw4ysog2bOSgD8QAJ06+xiWSB9yGj+NAujdlZYS yNGOA1HtJGkLSLZeyCDkhja89csqQlepLWWWoTrbizs0ajrXP9O3N7rGDhgfOSYN gWpFcAoNLdqQH2dWD3M63KNqqU+mfPrycqHTDo+9/cx55aASq/jnABgek9T037Wt lwcslrcGtqiGJ4KFULcZhwPmh4MiSe3IYc2uwbkdh5yGBDZK4iKhUumD88Euak7q Vafp6X45IT3+jMWbCYp0dEw9FHCGvxHKe/jgk+FdeUq+v6H58G988g8KDoy05QMC sDtpjPqVLPKXEG6o/VuT47ZhKo4pHkcogP3RC+zAGeYh9EiOxjexg03VaWE8YZx0 NaZ9d1clQrIrq8T8KK8TJOaJhSdwh7t5tsJn2DIbW9xquSO9AJCGnhIYIMeUY2vY v1QgQbXrSzo+IX5bNia6/GZYmGKjFh0v72l9hohAD1q26c/ifVQeoIDhOV1sRN3b tARZx8ZVG3Dph7Vq8lhvb4HBkc9ub4zjaEIsfiDo1YJB02hLaxxptUkmZSDHQECA cHtCfqBoXcAOcz9G30RiqEpVuoNiBG2F81Ey3CgxQFLY7mCI8ItnejUDmiWmz048 /s1WvVfYVvk21WEsfJi6cxWxlx8SSCtcpPXEp+e9V2ix0PMgSNlQW6ZMndQBMBYr wkpMD6ZEgODjcEmpnn4W =DdBC -----END PGP SIGNATURE----- --r4QXMf6/kyF/FvJJ--