From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4PDx-0002rH-0c for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4PDu-0002su-06 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:28 -0400 Date: Mon, 15 Jun 2015 16:59:08 +1000 From: David Gibson Message-ID: <20150615065908.GJ13352@voom.redhat.com> References: <1433478358-993-1-git-send-email-bharata@linux.vnet.ibm.com> <1433478358-993-6-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mPTHnM80CEnHQ2WJ" Content-Disposition: inline In-Reply-To: <1433478358-993-6-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: thuth@redhat.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com --mPTHnM80CEnHQ2WJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > Factor out bits of sPAPR specific CPU initialization code into > a separate routine so that it can be called from CPU hotplug > path too. >=20 > While at this, use MSR_EP define instead of using 6 directly. Don't do this please. MSR[EP] is an obsolete flag from 601. The MSR[IP] flag that we're controlling here just happened to re-use the same bit position, so using the existing MSR_EP define is misleading. A symbolic name is good, but you should create a new one for MSR[IP] instead. Or you could just drop this change and do the cleanup of the hardcoded 6 some other time. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --mPTHnM80CEnHQ2WJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVfne8AAoJEGw4ysog2bOSICwQAIQtHBu4/DgVQfUM/gRpktP3 n7k76APpoZrVBIGGpmmI3b+vkqdQ1J9EYhxj0/YACv2pSpp3w6wCJKlzjnHvKhun 6/7sSGVK0b+0gX+pBNdn2qAa6tln9wGf6zMQb5E4CeCRujfcgtUC0xB2RxCDRtR7 /9u8pr8+xsbnDIqH41knI3b7pIINxUw0p5u/Cn6srRzThIg4EP0DFvHDuUwIz+Lf Rb7yXak8Ka4vlZPeTYMFzn8n/IE93i9/gHSH3d8iDGuF7a5DwNo0upY1oprW3jPM b5JQO4l6XNBqQcisDBLLOdFTnDVdrjrFZLjQ7FyDRYhzEaXGhHNtqPYqux65+7EQ qMYogS46hNrpT8QfFK3EBZqetAGcn9LT+a0iHYumwREBxJD88JehsPr+/GVFfp/d 4fuHdbcOby1brrRDFUbhUELu9FseFDZ0W0flDbvzkspYN5rNp8pHuI1vQL/thVuO bIbntaQxHWoErjYzLGaLCx2WwtOtouT76v0WK4ETBPdT0YMhGVznSiCo1QQhwS/a sr7gf5dZTeQzJCoO6gWngGO0VZrTkrmu28NLzhpTrVO4PBW1FfUBcBBmKiMXAgpH 08gEiTlo8y79qYv+M/WaQ4i0LJ4SwP2/R83kou2vlE7ltFv5jz+XXRlK20VOKaTR cGcHqMMYpF6Brt1yaXul =YopX -----END PGP SIGNATURE----- --mPTHnM80CEnHQ2WJ--