From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4PDx-0002rJ-7O for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4PDt-0002sv-W4 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:29 -0400 Date: Mon, 15 Jun 2015 16:59:30 +1000 From: David Gibson Message-ID: <20150615065930.GK13352@voom.redhat.com> References: <1433478358-993-1-git-send-email-bharata@linux.vnet.ibm.com> <1433478358-993-8-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1ppIqr1kl39GnwQx" Content-Disposition: inline In-Reply-To: <1433478358-993-8-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 7/8] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: thuth@redhat.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com --1ppIqr1kl39GnwQx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 05, 2015 at 09:55:57AM +0530, Bharata B Rao wrote: > When supporting CPU hot removal by parking the vCPU fd and reusing > it during hotplug again, there can be cases where we try to reenable > KVM_CAP_IRQ_XICS CAP for the vCPU for which it was already enabled. > Introduce a boolean member in ICPState to track this and don't > reenable the CAP if it was already enabled earlier. >=20 > Re-enabling this CAP should ideally work, but currently it results in > kernel trying to create and associate ICP with this vCPU and that > fails since there is already an ICP associated with it. Hence this > patch is needed to work around this problem in the kernel. >=20 > This change allows CPU hot removal to work for sPAPR. >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --1ppIqr1kl39GnwQx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVfnfSAAoJEGw4ysog2bOSsIkP/0t6dysR1HVsPoadQWkTEGOn g2AtO4IHnJ2XSGb3G9ZP1csAU/d0zUF6mqlx0wRkTsyXib33G8OXb1rtLhQfi84W M0qBiYieY6xpXVVfFgF8lRPO2ILN0Glxcdme1U0tH7spFlTMk3kDWDLFe19yTnq9 S0+w+m1SpZExmMnX1VTon9kLYFmSYDRAYh901xxad+Ieq/zvd60R81wTfw76F0ba Ypo1FFFwGXs0o0BGPy1n0bDIRj2ZMvvJtCeFBgG8Lha9Jmp66L1uigs8jPHMndzB zLqb6vgtEaCe4j1oEcb6ifZvCxS5Fa8O6itBhRKFrHfu45mqbyeNY/mx5t4r1zy0 Kl3ily6xomjrQ4PyEsJjIN0y1lJRJdE0ffzBu0i3+6xbjmFYNo/ydbIyDXKuJ6fe brOx0Otq3ExTRaxhKuWZ7wCYeYrtEVmDUoeU8TiOAiytQm1dg4Eimp0oTaVDEZ+7 PT8z2Z4WMZIF9wfgvdSzISWAcgoU+FQ7msg5UIYR7pU/fRq0h7lwWw/8W3AwJkqc wM6g8iyjPs8MsOkUqjK4Eo7zzt/9/G/aM2OVGyQbXj/bRl4Ie1xMW3du0siuk6lq O13WfKU46ugl3vYf0WaKnIZAxl5yJkX4bB7TviOzTiUTYVQ8NCxuRiANzaR60GhM wJj5hxCZRgQ6ZrV9gphM =MC1h -----END PGP SIGNATURE----- --1ppIqr1kl39GnwQx--