From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4PDy-0002rs-Qm for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4PDu-0002t3-0w for qemu-devel@nongnu.org; Mon, 15 Jun 2015 03:54:30 -0400 Date: Mon, 15 Jun 2015 17:00:24 +1000 From: David Gibson Message-ID: <20150615070024.GL13352@voom.redhat.com> References: <1433478358-993-1-git-send-email-bharata@linux.vnet.ibm.com> <1433478358-993-9-git-send-email-bharata@linux.vnet.ibm.com> <55715942.2090201@ozlabs.ru> <20150605091559.GD25832@in.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iK/wEI4vkfDmI6Zw" Content-Disposition: inline In-Reply-To: <20150605091559.GD25832@in.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 8/8] xics_kvm: Add cpu_destroy method to XICS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: thuth@redhat.com, mdroth@linux.vnet.ibm.com, Alexey Kardashevskiy , agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com --iK/wEI4vkfDmI6Zw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 05, 2015 at 02:45:59PM +0530, Bharata B Rao wrote: > On Fri, Jun 05, 2015 at 06:09:38PM +1000, Alexey Kardashevskiy wrote: > > On 06/05/2015 02:25 PM, Bharata B Rao wrote: > > >XICS is setup for each CPU during initialization. Provide a routine > > >to undo the same when CPU is unplugged. Also ensure xics reset doesn't= set > > >irq for CPUs that are already unplugged. > > > > > >This allows reboot of a VM that has undergone CPU hotplug and unplug > > >to work correctly. > > > > > >Signed-off-by: Bharata B Rao > > >--- > > > hw/intc/xics.c | 14 ++++++++++++++ > > > hw/intc/xics_kvm.c | 15 +++++++++++++-- > > > include/hw/ppc/xics.h | 2 ++ > > > 3 files changed, 29 insertions(+), 2 deletions(-) > > > > > >diff --git a/hw/intc/xics.c b/hw/intc/xics.c > > >index 924b1ae..3f87f82 100644 > > >--- a/hw/intc/xics.c > > >+++ b/hw/intc/xics.c > > >@@ -44,6 +44,20 @@ static int get_cpu_index_by_dt_id(int cpu_dt_id) > > > return -1; > > > } > > > > > >+void xics_cpu_destroy(XICSState *icp, PowerPCCPU *cpu) > >=20 > >=20 > > xics_cpu_destroy() is not used by anything, may be push it later with t= he > > stuff which needs it? >=20 > Yeah it is not used in this patchset, will leave to David/agraf > to see if they want this dropped from this series. Drop it for now, please. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --iK/wEI4vkfDmI6Zw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVfngIAAoJEGw4ysog2bOSL6kP/18KwUk3BWk6iifCqaI2MZon JS8cIQyc/V854I8G543B8RfcfTST+a4kjfRqjPi0KdPvi3uuWYaY9OHB8Hg7kOjn 6p9d+YI8EOlrn7BQh2SYGWeq1jU2l+Tlf52o2HRE/M1ZvYL8QqGA3Nq4jmx30Gwj eKaQIZTnoTDliNXyRhO1lzh6ap3lDXTZGvJJyoFj53lc1g+Svrm+AEjwHLPHt4fN x7nXV0klFwSentkqqw0jCdaZmIWNjM5OkXmoBv2JARbiBw6k9Qmk++8tXBJF5ZSg HrNdujRt+oj1ovjt23u8zB4a4sXaeW2Px4SWLw3VHXC6BQrYQGWWqFpQS43LRJlK Ud+1uaY93i9XKpwajoo512wHv6G7XiuVNMOzeur4XtC44lds4LBroL1J6Olc+FDk 2X3er6STvupKqpyyVZTTxe4ycLXzgM6ZOPvwBS1Zg/B4LXrYmiQOoFiQ8kB2a++p C59jTCIZfmlUOZWrRy4JWVX7YmCVHyWqRYqlgOyx1lQhMXDi/OkcnDDKPR/tOo/J YKGaN3TWY0Njv0bZMQkbYDmegfhQw0rzPFmhkZNZGiPt5kLYA/w+GmTASWgz9mZ+ XY9ZP00Qow3euWkEW1Rd4AtV0dIrWH2WtF23cqfXCM6leYbVSjcTu4dJVpBz2+kK 6tqDCBEPKH9eQvNXnGkq =A9ar -----END PGP SIGNATURE----- --iK/wEI4vkfDmI6Zw--