From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4V4B-0001Qp-MB for qemu-devel@nongnu.org; Mon, 15 Jun 2015 10:08:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4V45-000586-S6 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 10:08:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4V45-00057p-MM for qemu-devel@nongnu.org; Mon, 15 Jun 2015 10:08:41 -0400 Date: Mon, 15 Jun 2015 15:08:38 +0100 From: Stefan Hajnoczi Message-ID: <20150615140838.GF9410@stefanha-thinkpad.redhat.com> References: <1432538908-26298-5-git-send-email-mukawa@igel.co.jp> <1432874550-10921-1-git-send-email-mukawa@igel.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lIrNkN/7tmsD/ALM" Content-Disposition: inline In-Reply-To: <1432874550-10921-1-git-send-email-mukawa@igel.co.jp> Subject: Re: [Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tetsuya Mukawa Cc: jasowang@redhat.com, qemu-devel@nongnu.org, n.nikolaev@virtualopensystems.com --lIrNkN/7tmsD/ALM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 29, 2015 at 01:42:26PM +0900, Tetsuya Mukawa wrote: > - Change user interface to be able to specify each feature by name. I disagree with this change, the uint64_t backend_features option was better because: The text options will just result in a very long command-line that is hard to read for humans. Instead of checking a bit in a single hex number, you have to scan over long comma-separated text options which can be in any arbitrary order to find the feature bit you were looking for. This option needs to be scripted or generated by a management tool anyway since it depends on the vhost-user backend program that is being paired with QEMU. The number of human users constructing these option is extremely low - if they use it they'll copy-paste it from their vhost-user program's documentation so the contents don't matter much (shorter is better though). The text options must be updated when new feature bits are added to virtio-net. For these reasons I find the numeric backend_features option better. --lIrNkN/7tmsD/ALM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVftxmAAoJEJykq7OBq3PIN/YH/2NQrkiduYQFmBIriEEr/NYm i/j8DzpZZe9T8DLM6XH4JKNzHLG3QSgv/aBQ2C3VWiCC2/b7rjXNU1FjhK0CBJPU 5E5ngPP2w4iVw2DiYg8LOtOStLaDpahB1ajUtNswrooSXg+Jo0fLed0FukutZ8Ob 3VgW+ZngQQSi972Ndu72xxYSlXyBHv92X52CvJRicDxhfCQVNAtkeYicqxMRTZUd HUgyruuyIcUrGzdHGB6++4+Ol7rKkU/AxiKBdlxclahhK8WFrc1/lMbjDlxBj9gG Nhw3rtPsteHzTq8LHeqXclRcs6DyD5vc9DLTjkSbLZ0vZi9tPsPXHsg7B75Mlws= =6mqO -----END PGP SIGNATURE----- --lIrNkN/7tmsD/ALM--