Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2088 bytes --]

On Sat, Jun 13, 2015 at 04:20:57PM +0200, Markus Armbruster wrote:
> In particular, don't include it into headers.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  backends/hostmem.c           | 1 -
>  balloon.c                    | 1 +
>  block.c                      | 1 +
>  block/backup.c               | 1 +
>  block/commit.c               | 1 +
>  block/mirror.c               | 1 +
>  block/qcow.c                 | 1 +
>  block/quorum.c               | 1 +
>  block/snapshot.c             | 1 +
>  block/stream.c               | 1 +
>  block/vmdk.c                 | 1 +
>  blockdev.c                   | 1 +
>  blockjob.c                   | 1 +
>  dump.c                       | 1 +
>  hmp.c                        | 1 +
>  hw/char/serial-pci.c         | 1 -
>  hw/dma/xilinx_axidma.c       | 1 -
>  hw/misc/ivshmem.c            | 1 -
>  hw/net/xilinx_axienet.c      | 1 -
>  hw/pci/pci-stub.c            | 1 +
>  hw/pci/pcie.c                | 1 -
>  hw/pci/shpc.c                | 1 -
>  hw/ppc/virtex_ml507.c        | 1 -
>  hw/s390x/s390-virtio.c       | 1 +
>  hw/usb/redirect.c            | 1 +
>  hw/virtio/virtio-rng.c       | 1 -
>  include/block/block_int.h    | 1 -
>  include/monitor/monitor.h    | 1 -
>  include/qemu/sockets.h       | 1 -
>  migration/migration.c        | 1 +
>  migration/savevm.c           | 1 +
>  monitor.c                    | 1 +
>  net/net.c                    | 1 +
>  numa.c                       | 1 -
>  qapi/qmp-output-visitor.c    | 1 -
>  qapi/string-output-visitor.c | 1 -
>  qdev-monitor.c               | 1 +
>  qemu-img.c                   | 1 +
>  qmp.c                        | 1 +
>  qobject/json-parser.c        | 1 -
>  scripts/qapi-commands.py     | 1 -
>  stubs/dump.c                 | 1 -
>  target-arm/cpu.c             | 1 -
>  target-i386/kvm.c            | 1 -
>  ui/vnc.c                     | 1 +
>  util/qemu-config.c           | 1 -
>  46 files changed, 25 insertions(+), 21 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]