From: Stefan Hajnoczi <stefanha@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h exactly where needed
Date: Mon, 15 Jun 2015 16:09:52 +0100 [thread overview]
Message-ID: <20150615150952.GG12553@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1434205258-1932-12-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]
On Sat, Jun 13, 2015 at 04:20:58PM +0200, Markus Armbruster wrote:
> In particular, don't include it into headers.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> balloon.c | 2 +-
> blockdev-nbd.c | 1 -
> hw/core/platform-bus.c | 1 -
> hw/display/qxl.c | 1 -
> hw/i386/pc.c | 1 -
> hw/ide/ahci.c | 1 -
> hw/ppc/spapr_vio.c | 1 -
> hw/s390x/event-facility.c | 1 -
> hw/s390x/s390-virtio-bus.c | 1 -
> hw/s390x/s390-virtio.c | 1 -
> hw/s390x/virtio-ccw.c | 1 -
> hw/usb/ccid-card-emulated.c | 1 -
> hw/usb/ccid-card-passthru.c | 1 -
> hw/usb/dev-serial.c | 1 -
> hw/usb/dev-smartcard-reader.c | 1 -
> hw/usb/hcd-ehci.h | 1 -
> hw/usb/redirect.c | 1 -
> include/block/block_int.h | 1 -
> include/monitor/qdev.h | 2 +-
> include/sysemu/balloon.h | 1 -
> include/ui/console.h | 2 +-
> include/ui/qemu-spice.h | 2 --
> migration/migration.c | 1 -
> net/l2tpv3.c | 1 -
> qmp.c | 1 +
> target-s390x/kvm.c | 1 -
> tpm.c | 1 -
> ui/input-legacy.c | 1 -
> ui/spice-display.c | 1 -
> 29 files changed, 4 insertions(+), 29 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-15 15:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 14:20 [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 01/11] QemuOpts: Wean off qerror_report_err() Markus Armbruster
2015-06-14 2:57 ` Eric Blake
2015-06-16 10:58 ` Markus Armbruster
2015-06-15 16:19 ` Stefan Hajnoczi
2015-06-13 14:20 ` [Qemu-devel] [PATCH 02/11] vl: Avoid qerror_report() outside QMP command handlers Markus Armbruster
2015-06-14 3:09 ` Eric Blake
2015-06-16 12:00 ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 03/11] vl: Use error_report() for --display errors Markus Armbruster
2015-06-15 12:49 ` Eric Blake
2015-06-13 14:20 ` [Qemu-devel] [PATCH 04/11] qerror: Eliminate QERR_DEVICE_NOT_FOUND Markus Armbruster
2015-06-15 13:59 ` Eric Blake
2015-06-16 12:26 ` Markus Armbruster
2015-06-15 15:13 ` Stefan Hajnoczi
2015-06-15 15:18 ` Luiz Capitulino
2015-06-15 20:33 ` Eric Blake
2015-06-16 12:28 ` Markus Armbruster
2015-06-15 20:41 ` Peter Maydell
2015-06-16 12:28 ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 05/11] qerror: Clean up QERR_ macros to expand into a single string Markus Armbruster
2015-06-15 15:12 ` Stefan Hajnoczi
2015-06-15 16:09 ` Eric Blake
2015-06-16 12:45 ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 06/11] tpm: Avoid qerror_report() outside QMP command handlers Markus Armbruster
2015-06-15 20:37 ` Eric Blake
2015-06-16 13:07 ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 07/11] qmp: Wean off qerror_report() Markus Armbruster
2015-06-15 15:08 ` Stefan Hajnoczi
2015-06-15 20:56 ` Eric Blake
2015-06-16 12:54 ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 08/11] qerror: Finally unused, clean up Markus Armbruster
2015-06-15 21:05 ` Eric Blake
2015-06-13 14:20 ` [Qemu-devel] [PATCH 09/11] qerror: Move #include out of qerror.h Markus Armbruster
2015-06-15 15:08 ` Stefan Hajnoczi
2015-06-15 21:37 ` Eric Blake
2015-06-13 14:20 ` [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed Markus Armbruster
2015-06-15 15:09 ` Stefan Hajnoczi
2015-06-15 21:38 ` Eric Blake
2015-06-16 12:58 ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h " Markus Armbruster
2015-06-15 15:09 ` Stefan Hajnoczi [this message]
2015-06-15 21:40 ` Eric Blake
2015-06-15 16:03 ` [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError Luiz Capitulino
2015-06-16 13:08 ` Markus Armbruster
2015-06-16 13:35 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615150952.GG12553@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).