From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Z4r1O-0001Ua-4m
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:35:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Z4r1J-00050C-3h
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:35:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52298)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Z4r1I-0004zY-Uu
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:35:17 -0400
Date: Tue, 16 Jun 2015 09:35:14 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20150616093514.291e8468@redhat.com>
In-Reply-To: <877fr3g5ra.fsf@blackfin.pond.sub.org>
References: <1434205258-1932-1-git-send-email-armbru@redhat.com>
	<20150615120304.7de9c59f@redhat.com>
	<877fr3g5ra.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mdroth@linux.vnet.ibm.com

On Tue, 16 Jun 2015 15:08:41 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Sat, 13 Jun 2015 16:20:47 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> After a bit over a year and many patches, QError is finally ripe.  All
> >> that's left of qerror.h after this series is a bunch of QERR_ macros.
> >> Killing them is left for another day.
> >
> > Excellent!
> >
> > I did my best to review this series, but unfortunately my review is
> > a bit weak because I'm not that familiar with some code paths
> > (like QemuOpts) and I was unable to apply patches starting with patch 04/11.
> 
> Did you apply on top of my "[PATCH v2 0/7] qdev: Mostly wean off
> QError"?

No, I assumed it was already merged.

> > But it does look good to me:
> >
> > Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> Thanks!
>