From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Z4rN3-0001rc-NS
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:57:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Z4rN0-0007k8-Er
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:57:45 -0400
Date: Tue, 16 Jun 2015 14:57:38 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150616135738.GA3132@stefanha-thinkpad.redhat.com>
References: <1433926791-10580-1-git-send-email-famz@redhat.com>
	<1433926791-10580-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL"
Content-Disposition: inline
In-Reply-To: <1433926791-10580-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] iohandler: Use aio code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, Paolo Bonzini <pbonzini@redhat.com>


--vtzGhvizbBRQ85DL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 10, 2015 at 04:59:44PM +0800, Fam Zheng wrote:
> diff --git a/iohandler.c b/iohandler.c
> index 826f713..f5d7704 100644
> --- a/iohandler.c
> +++ b/iohandler.c
> @@ -32,111 +32,39 @@
>  #include <sys/wait.h>
>  #endif
> =20
> -typedef struct IOHandlerRecord {
> -    IOHandler *fd_read;
> -    IOHandler *fd_write;
> -    void *opaque;
> -    QLIST_ENTRY(IOHandlerRecord) next;
> -    int fd;
> -    int pollfds_idx;
> -    bool deleted;
> -} IOHandlerRecord;
> +static AioContext *iohandler_ctx;

Please include a comment explaining why this AioContext is needed in
addition to the global qemu_aio_context.

--vtzGhvizbBRQ85DL
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVgCtSAAoJEJykq7OBq3PI9NkIAK8o3ojeVJSQ5u8Y2v8fTXdN
6N+7+PirZtwkWr8gGQJe7Ha459Y36IVWbYHvW/5B1vcpo3lCv217a+4/AXCP+BTy
bk6MDcmQH7Ji7BAKdVarF/87bPzoOHL4cuqUyZHFCsppTwQNeODLXRojyxd8vXKw
ES+CMv3osit1shnYXA4A0zGBYfhabQLT4X0SpPG6TNdp9GDmGDjo0av+m5aeqsIM
u4zrs5mmG8Da+eFcIEfqgp6iDPKRCllvBpH1S3bA5T28qZvox42CsawYnSPBRbet
c0B303d6sMNvf+NPvU91wXri+SJ6S0d3z7E9u5+iiTANzQx/TFiHfa1VGZYusTY=
=k35B
-----END PGP SIGNATURE-----

--vtzGhvizbBRQ85DL--