From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sBj-00017w-13 for qemu-devel@nongnu.org; Tue, 16 Jun 2015 10:50:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4sBf-0001jY-CR for qemu-devel@nongnu.org; Tue, 16 Jun 2015 10:50:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sBf-0001im-74 for qemu-devel@nongnu.org; Tue, 16 Jun 2015 10:50:03 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A51BB2CAF25 for ; Tue, 16 Jun 2015 14:50:02 +0000 (UTC) Date: Tue, 16 Jun 2015 16:49:59 +0200 From: "Michael S. Tsirkin" Message-ID: <20150616164912-mutt-send-email-mst@redhat.com> References: <1434458200-23440-1-git-send-email-mst@redhat.com> <1434458200-23440-2-git-send-email-mst@redhat.com> <55803671.50208@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55803671.50208@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, armbru@redhat.com On Tue, Jun 16, 2015 at 08:45:05AM -0600, Eric Blake wrote: > On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > > makes it possible to copy error_abort pointers, > > not just pass them on directly. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > util/error.c | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > Where is this patch needed? > > Is the goal to allow: > > Error err = error_abort; > > as a way to statically initialize err via copy to behave the same as the > global error_abort? > > But that's not how you were using it in patch 3. There, you were > initializing Error *, so using &error_abort is still useful there, and > pointer equality still suffices. No because &error_abort is Error **. > I don't see a convincing use for this patch. See cover letter for the motivation. > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >