From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4tt0-0007So-Uh for qemu-devel@nongnu.org; Tue, 16 Jun 2015 12:38:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4tsw-0003P0-Pl for qemu-devel@nongnu.org; Tue, 16 Jun 2015 12:38:54 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:40149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4tsw-0003OX-FK for qemu-devel@nongnu.org; Tue, 16 Jun 2015 12:38:50 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Jun 2015 17:38:48 +0100 Date: Tue, 16 Jun 2015 18:38:40 +0200 From: Greg Kurz Message-ID: <20150616183840.2892d596@bahia.local> In-Reply-To: <20150616162647.31380.65074.stgit@bahia.huguette.org> References: <20150616160925.31380.64020.stgit@bahia.huguette.org> <20150616162647.31380.65074.stgit@bahia.huguette.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] spapr_iommu: drop erroneous check in h_put_tce_indirect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Tue, 16 Jun 2015 18:26:47 +0200 Greg Kurz wrote: > The tce_list variable is not a TCE but the address to a TCE: we shouldn't > clear permission bits as we do now. And this is dead code anyway since we > check tce_list is 4K aligned a few lines above. > > This patch doesn't fix any bug, it is only code cleanup. > > Suggested-by: Alexey Kardashevskiy > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr_iommu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Of course, I did forget the changelog... v2: - suggested by aik - keep sPAPRTCEAccess, a translation helper is introduced in the next patch > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index 8cd9dba9ac4d..ddd0ea5cd4dd 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -267,9 +267,7 @@ static target_ulong h_put_tce_indirect(PowerPCCPU *cpu, > ioba &= page_mask; > > for (i = 0; i < npages; ++i, ioba += page_size) { > - target_ulong off = (tce_list & ~SPAPR_TCE_RW) + > - i * sizeof(target_ulong); > - tce = ldq_be_phys(cs->as, off); > + tce = ldq_be_phys(cs->as, tce_list + i * sizeof(target_ulong)); > > ret = put_tce_emu(tcet, ioba, tce); > if (ret) { > >